After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668464 - Use correct +/- buttons
Use correct +/- buttons
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jovanka
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-23 01:06 UTC by Danielle Madeley
Modified: 2013-01-08 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
correct buttons (3.70 KB, image/png)
2012-01-23 01:06 UTC, Danielle Madeley
  Details
an example of incorrect buttons (16.43 KB, image/png)
2012-01-23 01:07 UTC, Danielle Madeley
  Details
changed size od "-" button (791 bytes, patch)
2012-01-24 13:09 UTC, Jovanka
none Details | Review
block contacts - idea (15.72 KB, image/png)
2012-01-24 17:25 UTC, Jovanka
  Details
changed size od "-" button (7.00 KB, patch)
2012-01-24 23:01 UTC, Jovanka
reviewed Details | Review
Remove size group (878 bytes, patch)
2012-01-25 03:53 UTC, Jovanka
committed Details | Review
Toolbar and Treview merged (2.62 KB, patch)
2012-01-27 16:10 UTC, Jovanka
none Details | Review
Server field expanded (1.35 KB, patch)
2012-01-27 16:22 UTC, Jovanka
none Details | Review
irc-network-chooser-dialog: use GNOME 3 +/- buttons (3.90 KB, patch)
2013-01-08 14:11 UTC, Guillaume Desmottes
committed Details | Review

Description Danielle Madeley 2012-01-23 01:06:58 UTC
Created attachment 205843 [details]
correct buttons

Not all of the [+] and [-] buttons are in the correct GTK+ 3 style.

They should all be updated to be the correct style, use symbolic icons, and use the dark-grey tray attached to the treeview.

Known correct dialogs:
 - edit accounts

Known incorrect dialogs:
 - edit blocked contacts
 - manage favourites
 - edit custom messages
Comment 1 Danielle Madeley 2012-01-23 01:07:33 UTC
Created attachment 205844 [details]
an example of incorrect buttons

Incorrect size, no symbolic icons.
Comment 2 Guillaume Desmottes 2012-01-23 12:14:05 UTC
I had a WIP branch fixing this. I recorded in a cleaner way and uploaded it to:
http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=buttons-668464

Still to do:
- Double check that dialog are right
- Fix the IRC network dialog, the toolbar isn't properly merged with the treeview
- Fix the dialog listing IRC network (nothing done yet)
- Double check other Empathy dialog
Comment 3 Guillaume Desmottes 2012-01-23 13:03:15 UTC
Jovanka: can you please test and review this branch and then finish it as described above?
Comment 4 Jovanka 2012-01-23 14:30:41 UTC
Guillaume: of course I'll start right now.
Comment 5 Jovanka 2012-01-24 02:59:58 UTC
Guillaume: I checked and tested the branch. Those are the places where +/- buttons are placed. 
Except empathy-contact-blocking-dialog.ui everything else is ok. 
In empathy-contact-blocking-dialog.ui the - button is bigger since it has sizegroup assigned to it. So I think that we should change this. 
Also I wanted to ask if we should change Add button in this file to be + ?
Should I make this changes?
Comment 6 Danielle Madeley 2012-01-24 03:34:39 UTC
(In reply to comment #5)

> In empathy-contact-blocking-dialog.ui the - button is bigger since it has
> sizegroup assigned to it. So I think that we should change this. 
> Also I wanted to ask if we should change Add button in this file to be + ?
> Should I make this changes?

Yeah, get rid of the sizegroup. Make whatever changes make it look correct.
Comment 7 Guillaume Desmottes 2012-01-24 09:18:26 UTC
Agreed, just make it look like all the other places we use these buttons. :)
Comment 8 Jovanka 2012-01-24 13:09:52 UTC
Created attachment 205972 [details] [review]
changed size od "-" button

The button in empathy-contact-blocking-dialog.ui is set to have the same size as other buttons.
Comment 9 Jovanka 2012-01-24 17:25:56 UTC
Created attachment 205999 [details]
block contacts - idea

Since we decided to remove Add button from the 'Block Contact' dialog the previous patch should not be considered. So I rejected it. 

Allan also suggested to make it look like the attachment. So that would mean removing the account chooser and make a list. The other thing that he purposed is not to have the account name in the list, only the blocked contacts.
Comment 10 Jovanka 2012-01-24 23:01:35 UTC
Created attachment 206038 [details] [review]
changed size od "-" button

Changed size of "-" button and removed size group
Comment 11 Danielle Madeley 2012-01-24 23:11:42 UTC
Review of attachment 206038 [details] [review]:

This patch generates a lot of extra junk (this is caused by changing the Glade version). It also removes something important (this is due to an old Glade version).

This patch would be better if you used 'git add -p' to only select the important bit. Or it might just be easier to do with vim.

::: libempathy-gtk/empathy-contact-blocking-dialog.ui
@@ -84,3 @@
-            <style>
-              <class name="inline-toolbar"/>
-            </style>

You didn't want to lose this.
Comment 12 Jovanka 2012-01-25 03:53:19 UTC
Created attachment 206048 [details] [review]
Remove size group

Removig the size group will make '-' button same size as other '-' buttons.
Comment 13 Danielle Madeley 2012-01-25 04:16:10 UTC
Review of attachment 206048 [details] [review]:

++
Comment 14 Jovanka 2012-01-27 16:10:36 UTC
Created attachment 206276 [details] [review]
Toolbar and Treview merged

Fixes look of IRC network dialog, treeview and toolbar are properly merged
Comment 15 Jovanka 2012-01-27 16:22:09 UTC
Created attachment 206278 [details] [review]
Server field expanded

In IRC network dialog Port field was set to expand and Server field was too small, so now instead of that the Server field is set to expand so that the table looks better.
Comment 16 Guillaume Desmottes 2012-01-30 09:54:49 UTC
Jovanka: could you please publish a branch containing all your patches (and mine if you re-use some)? It would make testing easier as we already have a good number of patches around.
Comment 17 Jovanka 2012-02-17 07:34:48 UTC
https://github.com/JGulic/empathy
Comment 18 Guillaume Desmottes 2012-02-17 08:04:17 UTC
Hum that's not exactly what I was hoping for. Your git repo should be a clone from git://git.gnome.org/empathy and contain a branch with your patches as proper git commits.
Comment 19 Jovanka 2012-03-07 12:44:22 UTC
Hope that this is the right thing https://gitorious.org/~jgulic :)
Comment 20 Guillaume Desmottes 2012-03-07 13:32:00 UTC
That's the right kind of repo but the last commit (f3724393e2b41b04f0c0f865de373755993ce1ba) is wrong:
- Don't add anjuta files
- The 2 patches should be applied and recorded as a proper git commit, not included as it.
Comment 21 Jovanka 2012-03-09 15:43:30 UTC
https://gitorious.org/~jgulic
Is it ok now?
Comment 22 Danielle Madeley 2012-03-13 00:44:52 UTC
These two patches look fine. IIRC we're in UI freeze and need to ask for an exception to merge this branch (which is probably worth it).

The following hasn't been done:
 - IRC network selection dialog (buttons have not been moved to treeview bottom bar)
 - The patch for removing the size group (attachment 206048 [details] [review]) isn't in this branch
Comment 23 Danielle Madeley 2012-03-13 22:13:54 UTC
Ok, the branch has been merged. Only the IRC network selection dialog is outstanding.
Comment 24 Guillaume Desmottes 2013-01-08 14:11:57 UTC
Created attachment 232967 [details] [review]
irc-network-chooser-dialog: use GNOME 3 +/- buttons
Comment 25 Xavier Claessens 2013-01-08 14:17:59 UTC
+1
Comment 26 Guillaume Desmottes 2013-01-08 14:18:12 UTC
Attachment 232967 [details] pushed as 658d6dc - irc-network-chooser-dialog: use GNOME 3 +/- buttons