GNOME Bugzilla – Bug 668464
Use correct +/- buttons
Last modified: 2013-01-08 14:18:15 UTC
Created attachment 205843 [details] correct buttons Not all of the [+] and [-] buttons are in the correct GTK+ 3 style. They should all be updated to be the correct style, use symbolic icons, and use the dark-grey tray attached to the treeview. Known correct dialogs: - edit accounts Known incorrect dialogs: - edit blocked contacts - manage favourites - edit custom messages
Created attachment 205844 [details] an example of incorrect buttons Incorrect size, no symbolic icons.
I had a WIP branch fixing this. I recorded in a cleaner way and uploaded it to: http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=buttons-668464 Still to do: - Double check that dialog are right - Fix the IRC network dialog, the toolbar isn't properly merged with the treeview - Fix the dialog listing IRC network (nothing done yet) - Double check other Empathy dialog
Jovanka: can you please test and review this branch and then finish it as described above?
Guillaume: of course I'll start right now.
Guillaume: I checked and tested the branch. Those are the places where +/- buttons are placed. Except empathy-contact-blocking-dialog.ui everything else is ok. In empathy-contact-blocking-dialog.ui the - button is bigger since it has sizegroup assigned to it. So I think that we should change this. Also I wanted to ask if we should change Add button in this file to be + ? Should I make this changes?
(In reply to comment #5) > In empathy-contact-blocking-dialog.ui the - button is bigger since it has > sizegroup assigned to it. So I think that we should change this. > Also I wanted to ask if we should change Add button in this file to be + ? > Should I make this changes? Yeah, get rid of the sizegroup. Make whatever changes make it look correct.
Agreed, just make it look like all the other places we use these buttons. :)
Created attachment 205972 [details] [review] changed size od "-" button The button in empathy-contact-blocking-dialog.ui is set to have the same size as other buttons.
Created attachment 205999 [details] block contacts - idea Since we decided to remove Add button from the 'Block Contact' dialog the previous patch should not be considered. So I rejected it. Allan also suggested to make it look like the attachment. So that would mean removing the account chooser and make a list. The other thing that he purposed is not to have the account name in the list, only the blocked contacts.
Created attachment 206038 [details] [review] changed size od "-" button Changed size of "-" button and removed size group
Review of attachment 206038 [details] [review]: This patch generates a lot of extra junk (this is caused by changing the Glade version). It also removes something important (this is due to an old Glade version). This patch would be better if you used 'git add -p' to only select the important bit. Or it might just be easier to do with vim. ::: libempathy-gtk/empathy-contact-blocking-dialog.ui @@ -84,3 @@ - <style> - <class name="inline-toolbar"/> - </style> You didn't want to lose this.
Created attachment 206048 [details] [review] Remove size group Removig the size group will make '-' button same size as other '-' buttons.
Review of attachment 206048 [details] [review]: ++
Created attachment 206276 [details] [review] Toolbar and Treview merged Fixes look of IRC network dialog, treeview and toolbar are properly merged
Created attachment 206278 [details] [review] Server field expanded In IRC network dialog Port field was set to expand and Server field was too small, so now instead of that the Server field is set to expand so that the table looks better.
Jovanka: could you please publish a branch containing all your patches (and mine if you re-use some)? It would make testing easier as we already have a good number of patches around.
https://github.com/JGulic/empathy
Hum that's not exactly what I was hoping for. Your git repo should be a clone from git://git.gnome.org/empathy and contain a branch with your patches as proper git commits.
Hope that this is the right thing https://gitorious.org/~jgulic :)
That's the right kind of repo but the last commit (f3724393e2b41b04f0c0f865de373755993ce1ba) is wrong: - Don't add anjuta files - The 2 patches should be applied and recorded as a proper git commit, not included as it.
https://gitorious.org/~jgulic Is it ok now?
These two patches look fine. IIRC we're in UI freeze and need to ask for an exception to merge this branch (which is probably worth it). The following hasn't been done: - IRC network selection dialog (buttons have not been moved to treeview bottom bar) - The patch for removing the size group (attachment 206048 [details] [review]) isn't in this branch
Ok, the branch has been merged. Only the IRC network selection dialog is outstanding.
Created attachment 232967 [details] [review] irc-network-chooser-dialog: use GNOME 3 +/- buttons
+1
Attachment 232967 [details] pushed as 658d6dc - irc-network-chooser-dialog: use GNOME 3 +/- buttons