After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668393 - "Chat" button in "New Conversation" dialog shows missing icon
"Chat" button in "New Conversation" dialog shows missing icon
Status: RESOLVED NOTGNOME
Product: empathy
Classification: Core
Component: Artwork
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-21 13:58 UTC by Bilal Shahid
Modified: 2012-01-23 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
image (19.75 KB, image/png)
2012-01-23 16:57 UTC, Bilal Shahid 		Details

Description Bilal Shahid 2012-01-21 13:58:22 UTC 
Originally reported at:
  https://bugs.launchpad.net/bugs/597219

By the way, many of you might not see this bug as the gconf setting for button icons may have been set as disabled.
gconf is not assigning the icon to chat because i guess its not specified..
also i have tested with 3.3.4 it present in it.
Comment 1 André Klapper 2012-01-21 15:43:02 UTC 
Please provide exact steps, ALWAYS.
Your description is wrong as this is unrelated to any gconf keys (it is dconf instead).

1. Start dconf-editor and enable org->gnome->desktop->interface->buttons_have_icons
2. In Empathy, go to "Chat > New Conversation".
3. See that all three buttons have icons in empathy-3.2.2-1.fc16.i686.

(In reply to comment #0)
> also i have tested with 3.3.4 it present in it.

So in which version is the icon NOT present?
Comment 2 Bilal Shahid 2012-01-21 15:54:17 UTC 
yes it is present it 3.3.4 version.
Comment 3 André Klapper 2012-01-21 16:26:17 UTC 
Is there any debug output in the terminal when starting empathy 3.3.4 from a terminal window and going to that dialog? Or in ~/.xsession-errors ?
Comment 4 Guillaume Desmottes 2012-01-23 15:00:35 UTC 
I don't understand this bug. I just tried enabling this option and the 3 buttons do have an icon.
Comment 5 Bilal Shahid 2012-01-23 16:57:35 UTC 
Created attachment 205909 [details]
image

see we get no icon of chat there..i have mentioned in pic.
thanks
Comment 6 André Klapper 2012-01-23 18:07:10 UTC 
From http://git.gnome.org/browse/empathy/tree/libempathy-gtk/empathy-new-message-dialog.c#n319 :
  self->priv->button_chat = gtk_button_new_with_mnemonic (_("_Chat"));
  image = gtk_image_new_from_icon_name (EMPATHY_IMAGE_NEW_MESSAGE,
      GTK_ICON_SIZE_BUTTON);

And from libempathy-gtk/empathy-images.h:
#define EMPATHY_IMAGE_NEW_MESSAGE         "im-message-new"

Opening http://archive.ubuntu.com/ubuntu/pool/main/e/empathy/empathy_3.3.4-0ubuntu1.debian.tar.bz2 and going to the included file patches/10_use_notify_osd_icons.patch I see the lines

-#define EMPATHY_IMAGE_NEW_MESSAGE         "im-message-new"
+#define EMPATHY_IMAGE_NEW_MESSAGE         "notification-message-im"


So I'd REALLY appreciate investigation first (or an okay in the Launchpad bug report from a maintainer who knows the Ubuntu code changes) before upstreaming issues that are very likely not upstream issues.

Closing as NOTGNOME.