After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668379 - [h264parse] [codecparsers] gst_h264_parse_clock_timestamp always fails
[h264parse] [codecparsers] gst_h264_parse_clock_timestamp always fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-20 22:29 UTC by Jonas Larsson
Modified: 2012-01-23 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial patch to avoid falling through to the error handler when parsing succeeds (584 bytes, patch)
2012-01-20 22:29 UTC, Jonas Larsson 		committed Details | Review

Description Jonas Larsson 2012-01-20 22:29:13 UTC 
Created attachment 205734 [details] [review]
Trivial patch to avoid falling through to the error handler when parsing succeeds

gst_h264_parse_clock_timestamp in gst-libs/gst/codecparsers/gsth264parser.c always reports failure even when parsing actually succeeds. This is due to a missing return statement, causing a fall through to the error handler.
Comment 1 Vincent Penquerc'h 2012-01-23 18:32:56 UTC 
Thanks, pushed:

commit a07ffbda461513ed10477f3c5604867079b21cd8
Author: Jonas Larsson <jonas@hallerud.se>
Date:   Mon Jan 23 18:30:19 2012 +0000

    h264parse: fix gst_h264_parse_clock_timestamp always failing