Created attachment 205594 [details] [review]
express,fedora: Add user to 'wheel' group

Rather than manually editing the sudoers file.

Review of attachment 205594 [details] [review]:

Coming from a debian/ubuntu background, I prefer sudo. What's "wheel" really giving us compare to sudo?

I don't have opposition, but I think it would be preferable to comment why we prefer this vs sudo here, to not have to play ping-pong again

(In reply to comment #2)
> Review of attachment 205594 [details] [review]:
> 
> Coming from a debian/ubuntu background, I prefer sudo. What's "wheel" really
> giving us compare to sudo?

Its giving you exactly the same output, just without having to tweak that file directly (which we are not supposed to do anyway).

> I don't have opposition, but I think it would be preferable to comment why we
> prefer this vs sudo here, to not have to play ping-pong again


http://unix.stackexchange.com/questions/4405/how-to-make-fedora-user-a-sudoer

Still not convinced? talk to Ray. :)

(In reply to comment #3)
> (In reply to comment #2)
> > Review of attachment 205594 [details] [review] [details]:
> > 
> > Coming from a debian/ubuntu background, I prefer sudo. What's "wheel" really
> > giving us compare to sudo?
> 
> Its giving you exactly the same output, just without having to tweak that file
> directly (which we are not supposed to do anyway).

Apparently, no. sudo asks for your own password, and will remember it for a few minutes etc. otoh, su has a more annoying syntax (ie -c 'cmd') and will ask you the root password.

The point is perhaps for fedora that weel is more secure, because you need 2 passwords and each time you use su: first need to login and then root for each cmd...

> Still not convinced? talk to Ray. :)

My point is that the change should be motivated to bring something superior. If you replace solution A with solution B just because you can, I am going to be very suspicious.

If Fedora recommends using wheel, then that's an argument. I am quite sure the recommation for debian/ubuntu is sudo.

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Review of attachment 205594 [details] [review] [details] [details]:
> > > 
> > > Coming from a debian/ubuntu background, I prefer sudo. What's "wheel" really
> > > giving us compare to sudo?
> > 
> > Its giving you exactly the same output, just without having to tweak that file
> > directly (which we are not supposed to do anyway).
> 
> Apparently, no. sudo asks for your own password, and will remember it for a few
> minutes etc. otoh, su has a more annoying syntax (ie -c 'cmd') and will ask you
> the root password.

su? Who is talking about su here? this is all about sudo. Did you read the top answer on the link I provided?

We were adding the user to sudoers. With this patch we are making use of the fact that 'wheel' group is by default added to sudoers by fedora for us so all we need to do is add user to that group. Unless there is something wrong in this understanding of mine?

> > Still not convinced? talk to Ray. :)
> 
> My point is that the change should be motivated to bring something superior. If
> you replace solution A with solution B just because you can, I am going to be
> very suspicious.

I never ever do something just because I can. I always have reasons, if you agree or not or if I am wrong is another thing of course. :) Just saying that you don't need to explain this every now and then.

(In reply to comment #5)
> su? Who is talking about su here? this is all about sudo. Did you read the top
> answer on the link I provided?

I did, I also read a related question which was saying that on some system only wheel group could call su.

> We were adding the user to sudoers. With this patch we are making use of the
> fact that 'wheel' group is by default added to sudoers by fedora for us so all
> we need to do is add user to that group. Unless there is something wrong in
> this understanding of mine?

Now that you say it, I understand.

(In reply to comment #6)
> (In reply to comment #5)
> > su? Who is talking about su here? this is all about sudo. Did you read the top
> > answer on the link I provided?
> 
> I did, I also read a related question which was saying that on some system only
> wheel group could call su.

Well, as long as nobody from those distros act on this call, I wouldn't care at all. :) 

http://zee-nix.blogspot.com/2011/12/help-needed-for-debian-and-ubuntu.html

> > We were adding the user to sudoers. With this patch we are making use of the
> > fact that 'wheel' group is by default added to sudoers by fedora for us so all
> > we need to do is add user to that group. Unless there is something wrong in
> > this understanding of mine?
> 
> Now that you say it, I understand.

ACK then?

This needs to be explained more clearly in the commit log I guess :)

Created attachment 205639 [details] [review]
express,fedora: Add user to 'wheel' group

Fedora adds the 'wheel' group to sudoers for us so we can just add the
user to 'wheel' group rather than manually editing the sudoers file.

Review of attachment 205639 [details] [review]:

ack, thanks for the explanation

Forgot to use `git bz push` and then manually updating this bug I guess. :)