After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668206 - Cleanup LocationEntry vs. LocationAction
Cleanup LocationEntry vs. LocationAction
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-18 19:12 UTC by Cosimo Cecchi
Modified: 2012-01-19 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
entry: make EphyLocationEntry a GtkEntry (25.79 KB, patch)
2012-01-18 19:12 UTC, Cosimo Cecchi 		committed Details | Review
location-action: don't make this a GtkAction anymore (25.62 KB, patch)
2012-01-18 19:12 UTC, Cosimo Cecchi 		committed Details | Review
Rename EphyLocationAction -> EphyLocationController (42.51 KB, patch)
2012-01-18 19:12 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-01-18 19:12:11 UTC 
It's useful for EphyLocationEntry to be just a GtkEntry, and for EphyLocationAction not to be a GtkAction these days. This also simplifies the rest of the code.
Comment 1 Cosimo Cecchi 2012-01-18 19:12:13 UTC 
Created attachment 205570 [details] [review]
entry: make EphyLocationEntry a GtkEntry

Instead of a GtkToolItem. A future commit will merge the location action
with the location entry.
Comment 2 Cosimo Cecchi 2012-01-18 19:12:22 UTC 
Created attachment 205571 [details] [review]
location-action: don't make this a GtkAction anymore

It doesn't really make sense in a world where the location action is
only used on a fixed toolbar, and complicates the code a lot.
Comment 3 Cosimo Cecchi 2012-01-18 19:12:25 UTC 
Created attachment 205572 [details] [review]
Rename EphyLocationAction -> EphyLocationController

Since it's not a GtkAction anymore.
Comment 4 Cosimo Cecchi 2012-01-18 19:13:06 UTC 
(In reply to comment #1)

> Instead of a GtkToolItem. A future commit will merge the location action
> with the location entry.

This commit message is actually wrong; I went for the Entry <-> Controller pattern instead.
Comment 5 Xan Lopez 2012-01-19 16:15:28 UTC 
Review of attachment 205570 [details] [review]:

All seems sensible in this one, but please remember to fix the commit message.
Comment 6 Xan Lopez 2012-01-19 16:47:27 UTC 
Review of attachment 205571 [details] [review]:

OK. I think the code is not particularly easier, and this makes the location action the odd man out now, but I agree moving off GtkAction makes sense here.
Comment 7 Xan Lopez 2012-01-19 16:48:26 UTC 
Review of attachment 205572 [details] [review]:

OK.
Comment 8 Cosimo Cecchi 2012-01-19 18:07:56 UTC 
Attachment 205570 [details] pushed as 90e79ff - entry: make EphyLocationEntry a GtkEntry
Attachment 205571 [details] pushed as 2082e3a - location-action: don't make this a GtkAction anymore
Attachment 205572 [details] pushed as e622751 - Rename EphyLocationAction -> EphyLocationController

Thanks, pushed these to master now.