After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668192 - codecparsers: h264: fix ref_pic_list_modification()
codecparsers: h264: fix ref_pic_list_modification()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-18 16:13 UTC by Gwenole Beauchesne
Modified: 2012-01-20 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: h264: fix ref_pic_list_modification() (3.12 KB, patch)
2012-01-18 16:13 UTC, Gwenole Beauchesne 		none Details | Review

Description Gwenole Beauchesne 2012-01-18 16:13:01 UTC 
Created attachment 205536 [details] [review]
codecparsers: h264: fix ref_pic_list_modification()

The entries were not filled in linearly (index `i' was never incremented) and the termination was notr ecorded either. With the attached patch, the actual number of modifications is now recorded similarly to dec_ref_pic_marking(). i.e. an explicit counter is used instead of storing the termination value in the array.

Locally tested with the VA-API H.264 decoder.
Comment 1 Tim-Philipp Müller 2012-01-20 18:42:37 UTC 
commit c92efe38e9f3e60509449ce1bb0d5a6d880c337a
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Wed Jan 18 16:35:16 2012 +0100

    codecparsers: h264: fix ref_pic_list_modification()
    
    The entries were not filled in linearly and the termination was not
    recorded either. Now, the actual number of modifications is recorded
    similarly to dec_ref_pic_marking(). i.e. an explicit counter instead
    of storing the termination value in the array.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=668192