Created attachment 205486 [details] [review]
button: don't be active when holding the mouse button outside the bounds

GtkButton currently draws itself as active (pressed down) in case we're
pressing and holding the mouse pointer outside its bounds; this is
misleading though, since we won't activate the button unless the mouse
is released inside the button itself.
Fix this by only setting the ACTIVE state flag when the button is
actually pressed down.

Not convinced this is the right thing to do, as expressed on irc:

<cosimoc> mclasen, patch for one of the things mccann was reporting today: https://bugzilla.gnome.org/show_bug.cgi?id=668141
<cosimoc> mclasen, I yet have to test it some more, not sure it doesn't break anything else
<mclasen> dunno, to me, the keep-it-depressed-until-I-let-go is pretty deeply ingrained
<mclasen> I am always irritated by buttons that do it wong and snap back as soon as I move out
<mclasen> it kinda goes with the implicit grab
<mclasen> I would expect the button to snap back when the grab is broken
<cosimoc> mclasen, what
<cosimoc> ops
<cosimoc> mclasen, what's the point of keeping it depressed if it won't activate? it's misleading
<cosimoc> the button already snaps back when the grab is broken (at least, I see code that does that)
<mclasen> as I said, for me, the depressed visual is mentally connected to the grab
<cosimoc> not everybody knows what a grab is though :)
<mclasen> if I see the button snap back before I lift my finger, I have the impetus to check if my mouse button is broken
<cosimoc> even if the pointer is not on the button?
<mclasen> yeah
<mclasen> its different from hover
<mclasen> which you very much expect to go away if you move the pointer off
<mclasen> but then, maybe I'm just a grumpy old mouse user
<cosimoc> don't know...other platforms (e.g. osx) don't seem to keep it pressed
<cosimoc> not sure about windows

Attachment 205486 [details] pushed as 5495152 - button: don't be active when holding the mouse button outside the bounds