After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668113 - about dialog isn't modal
about dialog isn't modal
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-17 17:57 UTC by William Jon McCann
Modified: 2012-01-19 23:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-shell: pass active window to the about dialog (922 bytes, patch)
2012-01-17 20:18 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description William Jon McCann 2012-01-17 17:57:14 UTC 
The about dialog isn't modal and shows up in the gnome 3 overview. It should either be a modal dialog or be shown in the window itself as an "about:" page.
Comment 1 William Jon McCann 2012-01-17 17:58:14 UTC 
Oh also, maybe we shouldn't show "Web Website" in the about dialog. Or maybe call it "Developer site" or something.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-01-17 19:40:31 UTC 
I can do this one quickly, I think.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-01-17 20:18:09 UTC 
Created attachment 205480 [details] [review]
ephy-shell: pass active window to the about dialog

So it can be modal.
Comment 4 Xan Lopez 2012-01-17 20:20:07 UTC 
Isn't odd to have a global action be attached to a (random-ish) window? I think I wouldn't do this.
Comment 5 William Jon McCann 2012-01-17 20:24:40 UTC 
The focused window isn't at all random. There has to be a window that you load new links into anyway...

About windows should not be toplevel managed windows.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2012-01-17 20:25:22 UTC 
Well, it's attached to the active window.

I do think it's weird that the about dialog is floating freely, given other applications have it attached.

OTOH, if we make the dialog modal to the window, it apparently blocks other windows. Just like those old peeves we have/had with some modal dialogs.
Comment 7 Xan Lopez 2012-01-17 20:27:22 UTC 
(In reply to comment #5)
> The focused window isn't at all random. There has to be a window that you load
> new links into anyway...

It's random in the sense that the about dialog is now launched from the app menu, so we are just using the last active epiphany window. We could be using any other.

> 
> About windows should not be toplevel managed windows.

I think the point is that about dialogs don't work very well when launched from the app menu. I'd vote to move it to "about:" as we discussed. If we want to launch it from the app menu then I'd launch a new window with "about:" loaded, I guess.
Comment 8 William Jon McCann 2012-01-17 20:32:15 UTC 
Launching a new window seems like the worst solution, to be honest. The point is that we want to reduce the number of managed windows. We really expect there to be one window for most people, and there is only one active window at any time.

If you don't like using a modal window then just load "about:" into the active window as a tab/page.
Comment 9 Xan Lopez 2012-01-18 12:25:41 UTC 
I think going forward I'd just get rid of About in the app menu and have the information accessible only by typing "about:" in the URL entry. In the meantime we can commit this, though.
Comment 10 Xan Lopez 2012-01-18 12:26:13 UTC 
Review of attachment 205480 [details] [review]:

OK.
Comment 11 Diego Escalante Urrelo (not reading bugmail) 2012-01-19 23:49:36 UTC 
Attachment 205480 [details] pushed as 1d566cf - ephy-shell: pass active window to the about dialog