After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668074 - Wrong icon sizes for some icons
Wrong icon sizes for some icons
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: HighContrast
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
: 676114 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-01-17 07:45 UTC by Vincent Untz
Modified: 2014-07-27 23:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
HC: provide legacy gtk stock icons (187.12 KB, patch)
2014-05-05 15:13 UTC, Jakub Steiner
committed Details | Review

Description Vincent Untz 2012-01-17 07:45:25 UTC
rpmlint finds those:

/usr/share/icons/HighContrast/48x48/stock/gtk-dnd-multiple.png expected: 48x48 actual: 32x32
/usr/share/icons/HighContrast/48x48/stock/gtk-dnd.png expected: 48x48 actual: 32x32
/usr/share/icons/HighContrastInverse/48x48/stock/double-click-maybe.png expected: 48x48 actual: 100x100
/usr/share/icons/HighContrastInverse/48x48/stock/double-click-off.png expected: 48x48 actual: 100x100
/usr/share/icons/HighContrastInverse/48x48/stock/double-click-on.png expected: 48x48 actual: 100x100
/usr/share/icons/HighContrastInverse/48x48/stock/gtk-dnd-multiple.png expected: 48x48 actual: 32x32
/usr/share/icons/HighContrastInverse/48x48/stock/gtk-dnd.png expected: 48x48 actual: 32x32
/usr/share/icons/LowContrast/48x48/stock/gtk-apply.png expected: 48x48 actual: 44x45
/usr/share/icons/LowContrast/48x48/stock/gtk-dnd-multiple.png expected: 48x48 actual: 32x32
/usr/share/icons/LowContrast/48x48/stock/gtk-dnd.png expected: 48x48 actual: 32x32
/usr/share/icons/LowContrast/48x48/stock/gtk-ok.png expected: 48x48 actual: 44x45
/usr/share/icons/LowContrast/48x48/stock/media-playback-pause.png expected: 48x48 actual: 24x24
/usr/share/icons/LowContrast/48x48/stock/media-playback-start.png expected: 48x48 actual: 24x24
Comment 1 Cosimo Cecchi 2012-05-15 17:13:16 UTC
*** Bug 676114 has been marked as a duplicate of this bug. ***
Comment 2 Emilio Pozuelo Monfort 2013-03-25 17:32:34 UTC
Still an issue for these two icons:

$ file themes/HighContrast/icons/48x48/stock/gtk-dnd*
themes/HighContrast/icons/48x48/stock/gtk-dnd-multiple.png: PNG image data, 32 x 32, 8-bit/color RGBA, non-interlaced
themes/HighContrast/icons/48x48/stock/gtk-dnd.png:          PNG image data, 32 x 32, 8-bit/color RGBA, non-interlaced
Comment 3 Jakub Steiner 2014-05-05 14:51:14 UTC
I've provided a -symbolic style set of the legacy stock icons so they get treated the same way as everything else (gnome-icon-theme-symbolic->adwaita + app icons).

https://github.com/gnome-design-team/gnome-icons/tree/master/legacy/stock-symbolic/gnome

Unfortunately there seems to be a regression in the xinclude part of the create-highcontrast utility in gnome-themes-standard when suddenly the stylesheet injection/wrap produces a blank icon for everything.
Comment 4 Jakub Steiner 2014-05-05 15:13:35 UTC
Created attachment 275893 [details] [review]
HC: provide legacy gtk stock icons
Comment 5 Jakub Steiner 2014-05-05 15:14:47 UTC
Attachment 275893 [details] pushed as 5b3f66b - HC: provide legacy gtk stock icons
Comment 6 Leho Kraav (@lkraav :macmaN) 2014-07-27 23:19:46 UTC
Is this why after upgrading to Gnome 3.12, gthumb and remmina cry about missing icons?

(gthumb:28055): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion 'G_IS_LOADABLE_ICON (icon)' failed

(gthumb:28055): Gtk-WARNING **: Error loading theme icon 'gtk-edit' for stock: Failed to load icon

(gthumb:28055): Gtk-CRITICAL **: render_fallback_image: assertion 'pixbuf != NULL' failed

(gthumb:28055): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

(gthumb:28055): Gdk-CRITICAL **: gdk_cairo_surface_create_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(gthumb:28055): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

...(repeat cycle multiple times here)
Comment 7 Leho Kraav (@lkraav :macmaN) 2014-07-27 23:21:15 UTC
leho@xps14 icons $ pwd
/usr/share/icons
leho@xps14 icons $ find -name gtk-edit*
./HighContrast/48x48/stock/gtk-edit.png

Is this all I'm supposed to have with gnome-themes-standard-3.12.0?