After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668035 - gtester-report broken with python 2.7.2 and glib 2.30.1
gtester-report broken with python 2.7.2 and glib 2.30.1
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-01-16 17:52 UTC by Paolo Bonzini
Modified: 2017-10-11 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ignore 'package' and 'version' if missing (1.22 KB, patch)
2012-08-14 18:37 UTC, Jason Conti 		committed Details | Review

Description Paolo Bonzini 2012-01-16 17:52:43 UTC 
Unless I manually add a <info> element to gtester, I get the following error:

Traceback (most recent call last):

+ Trace 229459

  • File "/usr/bin/gtester-report", line 492 in <module> 
    main()
  • File "/usr/bin/gtester-report", line 486 in main 
    HTMLReportWriter(rr.get_info(), rr.binary_list()).printout()
  • File "/usr/bin/gtester-report", line 350 in printout 
    self.handle_info ()
  • File "/usr/bin/gtester-report", line 244 in handle_info 
    self.oprint ('<h3>Package: %(package)s, version: %(version)s</h3>\n' % self.info)

This is on a Fedora 16 distribution, which adds no gtest-related patches to the upstream tarball.
Comment 1 Paolo Bonzini 2012-01-16 17:53:31 UTC 
Oops, cut out the end of the trace:

KeyError: 'package'
Comment 2 Jason Conti 2012-08-14 18:37:51 UTC 
Created attachment 221181 [details] [review]
Ignore 'package' and 'version' if missing

Fix is easy enough, just ignore 'package' and 'version' if they are missing. Includes a small change to the following line for 'revision', since if the revision tag is missing, it will fail with another exception.
Comment 3 sébastien lafargue 2015-04-23 09:29:55 UTC 
Hi, this patch works, can we push it ?
Comment 4 Philip Withnall 2017-10-11 09:42:04 UTC 
Review of attachment 221181 [details] [review]:

Looks good; might as well push it, even though gtester-report is heavily deprecated in favour of glib-tap.mk now.