After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668016 - Accidentally clicking ruler loses active tool's state
Accidentally clicking ruler loses active tool's state
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.8.10
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 543700 712721 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-01-16 14:13 UTC by Kevin Brubeck Unhammer
Modified: 2016-04-03 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kevin Brubeck Unhammer 2012-01-16 14:13:34 UTC
(I discovered this a while ago and can't remember whether I reported it or not, couldn't find a report of it though.)

How to reproduce:
1. (optional, but typical) zoom in so canvas at least reaches a ruler edge
2. click F and start selecting near the ruler edge
3. miss the canvas hand click the ruler

Actual result:
4. lose whole selection since the tool changes to Move tool

Expected result:
4. nothing happens (since there's an ongoing selection being made, in which case creating a guide would be unlikely)
Comment 1 Kevin Brubeck Unhammer 2012-12-06 08:19:57 UTC
sorry, step 3 should say

3. miss the canvas and click the ruler


The bug is still present in 2.8.2
Comment 2 Michael Natterer 2013-11-20 21:53:45 UTC
*** Bug 712721 has been marked as a duplicate of this bug. ***
Comment 3 scott092707 2015-03-21 20:28:39 UTC
Bug is still present in 2.8.10.  Don't know about 2.8.14, as it is not in my Lubuntu 14.10 repo.  (Perhaps won't be - perhaps must install 15.04 next month to get it?)

Naturally, one can turn off the rulers.
However, newer users (and the forgetful) will not know/remember to do this, and one can instantly lose a HUGE amount of work by accidentally hitting the ruler.

Bug 712721 involves INTENTIONALLY selecting the ruler, to bring out a guide (for use in the Perspective Tool, to line things up, apparently).
Here one did not MEAN to hit the ruler, or bring out a guide (not all that useful for freehand select, I would think), so I am unsure if it is a duplicate of this bug.

Has any work been done on this?

One could make the pull-guide-out-of-ruler thing something that would have to be enabled with a menu option, which would then maybe put up a warning that all work in Freehand Select or Perspective Tool (or ,,, ?) would be lost.

Ideally, FS and PT could be made less fragile...?
Is Paths Tool this fragile? - if not, perhaps FS and PT could emulate part of the procedure for planting points that Paths Tool uses...
Comment 4 Michael Natterer 2016-04-03 14:42:24 UTC
Fixed in master:

commit 7889ec08f7c2bd119ddbdc8982272597e340721a
Author: Michael Natterer <mitch@gimp.org>
Date:   Sun Apr 3 16:27:41 2016 +0200

    Bug 668016 - Accidentally clicking ruler loses active tool's state
    
    Add two new tools, GimpGuideTool and GimpSamplePointTool. They are
    one-trick-ponies and can only create new or move existing guides and
    sample points. They can't be selected from the toolbox, only
    temporarily pushed as active tools on top of any active tool using
    their public start() APIs.
    
    Use that API to enable them when the rulers are clicked, and replace
    the entire guide and sample point moving code in GimpMoveTool and
    GimpColorTool by simple calls to that API.
    
    This might look like overkill but can easily be used for other
    features like moving guides from within the paint tools (mirror
    painting) or gegl filters (preview curtain).

 app/display/gimpdisplayshell-tool-events.c |  60 ++---
 app/tools/Makefile.am                      |   4 +
 app/tools/gimpcolortool.c                  | 225 +----------------
 app/tools/gimpcolortool.h                  |  16 +-
 app/tools/gimpguidetool.c                  | 390 +++++++++++++++++++++++++++++
 app/tools/gimpguidetool.h                  |  61 +++++
 app/tools/gimpmovetool.c                   | 324 ++----------------------
 app/tools/gimpmovetool.h                   |   4 -
 app/tools/gimpsamplepointtool.c            | 348 +++++++++++++++++++++++++
 app/tools/gimpsamplepointtool.h            |  60 +++++
 po/POTFILES.in                             |   2 +
 11 files changed, 925 insertions(+), 569 deletions(-)
Comment 5 Michael Natterer 2016-04-03 14:44:11 UTC
*** Bug 543700 has been marked as a duplicate of this bug. ***