GNOME Bugzilla – Bug 667980
Port python plugins/scripts from dbus-python to PyGI
Last modified: 2018-05-24 17:18:01 UTC
Created attachment 205321 [details] [review] Port im-status plugin from dbus-python/dbus-glib to PyGI/GDBus The following files in the RB source tree use dbus-python: plugins/im-status/im-status.py remote/dbus/rb-print-playing.py remote/dbus/rb-set-rating.py The attached patch converts the im-status plugin to PyGI (gdbus). Patches for the two scripts will follow later.
Created attachment 205328 [details] [review] Port the rb-set-rating.py example script to PyGI/GDBus I'm having some problems with the other script[1], so this one is attached separately. 1. Connecting a callback to the "g-properties-changed" DBusProxy signal causes a buffer overflow when the signal is emitted. Seems to be a pygobject bug.
I filed bug 667983 in pygobject about "g-properties-changed".
Review of attachment 205321 [details] [review]: pushed as commit 63a470c, thanks
Review of attachment 205328 [details] [review]: ::: remote/dbus/rb-set-rating.py @@ +17,3 @@ +entry_uri = sys.argv[1] +rating = float(sys.argv[2]) +vrating = GLib.Variant("u", rating) shouldn't this be "d"?
(In reply to comment #4) > Review of attachment 205328 [details] [review]: > > ::: remote/dbus/rb-set-rating.py > @@ +17,3 @@ > +entry_uri = sys.argv[1] > +rating = float(sys.argv[2]) > +vrating = GLib.Variant("u", rating) > > shouldn't this be "d"? You're right, it should be a double. I guess dbus got a bit liberal and accepted uint32 anyway.
Created attachment 205347 [details] [review] Port the rb-set-rating.py example script to PyGI/GDBus Changes uint32 to double as is required by the RhythmDB backend; tested to work.
Review of attachment 205347 [details] [review]: pushed as commit c553358, thanks
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1148.