After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667954 - test_properties.TestProperties.testRange fails under Gentoo Linux
test_properties.TestProperties.testRange fails under Gentoo Linux
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-15 11:50 UTC by Toralf Förster
Modified: 2013-01-08 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build log (28.02 KB, application/x-gzip)
2012-04-23 17:50 UTC, Toralf Förster
Details
build log (160.56 KB, text/x-log)
2013-01-08 16:17 UTC, Toralf Förster
Details

Description Toralf Förster 2012-01-15 11:50:48 UTC
======================================================================
ERROR: testRange (test_properties.TestProperties)
----------------------------------------------------------------------
Traceback (most recent call last):
  • File "/var/tmp/portage/dev-python/pygobject-3.0.2/work/pygobject-3.0.2-3.1/tests/test_properties.py", line 245 in testRange
    obj.set_property(key, max)
TypeError: could not convert argument to correct param type

----------------------------------------------------------------------
Ran 90 tests in 0.853s
FAILED (errors=1)


My system is an almost stable Gentoo system.
Comment 1 Toralf Förster 2012-01-15 13:56:43 UTC
Here are more info : https://bugs.gentoo.org/show_bug.cgi?id=396505
Comment 2 André Klapper 2012-01-15 14:07:48 UTC
Please post the URL in the downstream report and paste useful information from downstream here in this report so it's searchable.
Comment 3 Toralf Förster 2012-01-15 15:18:35 UTC
Tests fail because ebuild tries to run ipv6 tests though no ipv6 support is
available. It passes tests when ipv6 support is there (in the kernel config).
Comment 4 Martin Pitt 2012-04-23 17:06:32 UTC
This is a bug report against glib, not pygobject, reassigning.
Comment 5 Martin Pitt 2012-04-23 17:09:05 UTC
Erk, sorry. I was looking in the referenced upstream bug (https://bugs.gentoo.org/show_bug.cgi?id=396505), which is against glib (testing IPv6 sockets). So this is not the bug we are looking for.

Is this still an issue for you with current PyGObject 3.2.0 and GLib 2.32? If so, which architecture is that?
Comment 6 Toralf Förster 2012-04-23 17:50:52 UTC
Created attachment 212628 [details]
build log

I re-tested it again here under an up-to-date stable x86 Gentoo and got :

======================================================================
FAIL: test_python_calls_sync (test_gdbus.TestGDBusClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  • File "/var/tmp/portage/dev-python/pygobject-3.0.2/work/pygobject-3.0.2-2.7/tests/test_gdbus.py", line 134 in test_python_calls_sync
    self.assertTrue('Timeout' in str(e), str(e))
AssertionError: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Call to GetConnectionUnixProcessID has wrong args (, expected s)

Comment 7 Martin Pitt 2012-04-23 18:06:16 UTC
OK, that's an entirely different error now. It's actually supposed to time out immediately, but that might be different with newer D-BUS versions.
Comment 8 Martin Pitt 2012-04-23 18:10:54 UTC
Should be fixed with

http://git.gnome.org/browse/pygobject/commit/?id=b9f24b4fbc2ca9f9b94b86f029c59b2fc3e8590f

Can you please re-test with this patch or with current upstream git master? Thanks!
Comment 9 Toralf Förster 2012-04-23 20:05:48 UTC
(In reply to comment #8)
> Should be fixed with
> 
> http://git.gnome.org/browse/pygobject/commit/?id=b9f24b4fbc2ca9f9b94b86f029c59b2fc3e8590f
> 
> Can you please re-test with this patch or with current upstream git master?
> Thanks!
Hhm, with that pacth on top of 3.0.2 I get :

======================================================================
ERROR: testRange (test_properties.TestProperties)
----------------------------------------------------------------------
Traceback (most recent call last):
  • File "/var/tmp/portage/dev-python/pygobject-3.0.2/work/pygobject-3.0.2-3.2/tests/test_properties.py", line 245 in testRange
    obj.set_property(key, max)
TypeError: could not convert argument to correct param type

----------------------------------------------------------------------
Comment 10 Martin Pitt 2012-04-24 04:53:00 UTC
This is a completely unrelated test to the gdbus one (and back to the original), so I assume you got that failure before already? Can you please check whether this test case still fails with the 3.2.0 release tarball or master?
Comment 11 Martin Pitt 2012-04-24 04:55:03 UTC
Also, can you please add some print statements there which show the values of "key", "gtype", "min", and "max" in the loop, so that we can see where it's failing?
Comment 12 Toralf Förster 2012-04-24 11:38:51 UTC
(In reply to comment #10)
The stable Gentoo stills stays at dev-libs/glib-2.30.2, therefore the test cannot be run here at my machine.

(In reply to comment #11)
> Also, can you please add some print statements there which show the values of
> "key", "gtype", "min", and "max" in the loop, so that we can see where it's
> failing?
I'm not too familiar with Python and don't want to introduce own bugs, do you have patches for that ?
Comment 13 Martin Pitt 2012-06-01 08:28:24 UTC
Something like:

--- a/tests/test_properties.py
+++ b/tests/test_properties.py
@@ -355,6 +355,7 @@ class TestProperties(unittest.TestCase):

         obj = RangeCheck()
         for key, (gtype, min, max) in types.items():
+            print('checking: key %s, gtype %s, min %s, max %s' % (key, gtype, min, max))
             self.assertEqual(obj.get_property(key),
                              getattr(RangeCheck.props, key).default_value)


and then copy&pasting the output from

TEST_NAMES=test_properties.TestProperties.testRange make check

Thanks!
Comment 14 Tobias Mueller 2012-10-17 10:00:33 UTC
Toralf, can you work with the patch provided?
Comment 15 Toralf Förster 2012-10-17 17:41:07 UTC
(In reply to comment #14)
> Toralf, can you work with the patch provided?

I could, but first /me wonders what's with this comment
https://bugs.gentoo.org/show_bug.cgi?id=396505#c9 ?
Comment 16 Martin Pitt 2013-01-08 15:26:47 UTC
(In reply to comment #15)
> I could, but first /me wonders what's with this comment
> https://bugs.gentoo.org/show_bug.cgi?id=396505#c9 ?

Wrong bug? This looks unrelated.

Anyway, this bug has been lingering around without being reproducible for months. Is it still actually an issue in current Gentoo with current pygobject?
Comment 17 Toralf Förster 2013-01-08 16:17:52 UTC
Created attachment 232980 [details]
build log

This is the current situation :

======================================================================
FAIL: test_python_calls_sync (test_gdbus.TestGDBusClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  • File "/var/tmp/portage/dev-python/pygobject-3.2.2/work/pygobject-3.2.2-2.7/tests/test_gdbus.py", line 134 in test_python_calls_sync
    self.assertTrue('Timeout' in str(e), str(e))
AssertionError: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Could not get PID of name '1': no such name

Comment 18 Martin Pitt 2013-01-08 16:28:47 UTC
(In reply to comment #17)
> This is the current situation :
> 
> ======================================================================
> FAIL: test_python_calls_sync (test_gdbus.TestGDBusClient)

This got fixed in http://git.gnome.org/browse/pygobject/commit/?id=94a6cc93

So it seems the rest works now, so we can close this.

Thanks!

Martin