After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667840 - Add annotations from Vala bindings
Add annotations from Vala bindings
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-13 02:20 UTC by Evan Nemerson
Modified: 2012-02-01 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: add some missing annotations (5.69 KB, patch)
2012-01-13 02:38 UTC, Evan Nemerson 		accepted-commit_now Details | Review

Description Evan Nemerson 2012-01-13 02:20:37 UTC 
Some annotation improvements ported from the Vala bindings... patch will be attached momentarily.
Comment 1 Evan Nemerson 2012-01-13 02:38:59 UTC 
Created attachment 205156 [details] [review]
introspection: add some missing annotations

I don't think there is anything in this which is wrong, but there are two bits that are a bit odd.

First, the two arrays passed to clutter_list_model_newv share a length parameter. While the annotation I used is, I believe, correct, Vala /may/ be the only consumer which is okay with this right now... it might be best to just skip this function.

Second, one part of this touches ClutterTimeoutPool (which is deprecated and skipped). The Vala bindings are older than the GIR and we need to provide this for backwards compatibility. Since it's skipped in the GIR I doubt anyone else will care.
Comment 2 Evan Nemerson 2012-01-13 03:07:27 UTC 
IRC a few minutes ago:

<nemequ> are multiple arrays with a single length parameter supported? e.g., clutter_list_model_newv
<walters> nemequ, mmm...probably
<walters> but it's a bit tricky and may trigger bugs in the invocation path
Comment 3 Emmanuele Bassi (:ebassi) 2012-01-24 12:37:57 UTC 
Review of attachment 205156 [details] [review]:

looks okay to me
Comment 4 Evan Nemerson 2012-02-01 00:58:13 UTC 
commit 4b6156a57a00214297c696f20e374ad645b97019
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Thu Jan 12 18:15:55 2012 -0800

    introspection: add some missing annotations
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667840