After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667722 - decklinksrc will accept any caps
decklinksrc will accept any caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.22
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-11 22:49 UTC by blake tregre
Modified: 2012-03-17 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch checking caps before accepting them (2.81 KB, patch)
2012-01-11 22:49 UTC, blake tregre 		none Details | Review

Description blake tregre 2012-01-11 22:49:23 UTC 
Created attachment 205050 [details] [review]
patch checking caps before accepting them

The caps on the video pad are determined by the property 'mode', and the caps on the audio pad are fixed.  The accept caps function will accept (that is, return TRUE) any caps, but should probably only return TRUE if the caps are the same.  This is probably just nit-picking (and possibly incorrect), but the attached patch checks to see if the incoming caps intersect with the caps that are already set.
Comment 1 David Schleef 2012-03-17 21:31:36 UTC 
commit 18475dd0c229aa23a52add001f3d829cf0eb62ba
Author: blake tregre <blake@oblong.com>
Date:   Mon Oct 31 18:58:34 2011 -0700

    decklinksrc: make sure we can accept caps before returning true
    
    caps are determined by the plugin's properties, so we should check the
    incoming caps to see if they agree.  Fixes: #667722.