GNOME Bugzilla – Bug 667689
gststructure: clarify _get docs about the returned reference
Last modified: 2012-01-11 12:57:08 UTC
gststructure: clarify _get docs about the returned reference I was confused by these docs. To me, "you will acquire your own reference" means "you need to call _ref yourself", whereas what the code does it give you an already reffed pointer. Test code shows that a ref is indeed returned (at least for caps, which is what I tested). I think this is a lot clearer, but then I'm not a native English speaker so maybe I'm missing a subtlety here, so I'll put that up for comments before pushing.
Created attachment 205016 [details] [review] gststructure: clarify _get docs about the returned reference
Comment on attachment 205016 [details] [review] gststructure: clarify _get docs about the returned reference Makes sense and is much clearer IMHO.
Thanks. I still had this nagging feeling I might have been missing something :) commit 98c99630ad55d502cb4e75feb2272dd0d50b92e5 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Jan 11 12:19:20 2012 +0000 gststructure: clarify _get docs about the returned reference https://bugzilla.gnome.org/show_bug.cgi?id=667689