After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667573 - various srcdir != builddir fixes
various srcdir != builddir fixes
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-09 15:47 UTC by Allison Karlitskaya (desrt)
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
various srcdir != builddir fixes (4.62 KB, patch)
2012-01-09 15:47 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
Change style of toplevel installed headers (3.91 KB, patch)
2012-01-09 16:20 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-01-09 15:47:23 UTC 
see patch
Comment 1 Allison Karlitskaya (desrt) 2012-01-09 15:47:25 UTC 
Created attachment 204876 [details] [review]
various srcdir != builddir fixes
Comment 2 Stef Walter 2012-01-09 16:11:15 UTC 
Review of attachment 204876 [details] [review]:

Looks good, although I would change all the links in gcr.h and gcr-base.h to use the <gcr/xxx.h> form you described.
Comment 3 Allison Karlitskaya (desrt) 2012-01-09 16:20:37 UTC 
Created attachment 204882 [details] [review]
Change style of toplevel installed headers

Use <gcr/xxx.h> instead of "xxx.h" style.
Comment 4 Allison Karlitskaya (desrt) 2012-01-09 16:20:55 UTC 
Attachment 204876 [details] pushed as a3cdb51 - various srcdir != builddir fixes
Attachment 204882 [details] pushed as db8d420 - Change style of toplevel installed headers