GNOME Bugzilla – Bug 667540
Desynchronized size between ClutterStageCogl and ClutterStageX11
Last modified: 2012-02-15 11:37:26 UTC
Created attachment 204859 [details] [review] Patch v1 If you execute the following sequence : stage = clutter_stage_new (); clutter_actor_set_size (stage, 1280, 800); clutter_actor_realize (stage); Then you end up when ClutterStageCogl creating an onscreen buffer of size 1280x800 but ClutterStageX11 storing the stage size at 640x480.
can I get a patch against master?
Created attachment 205968 [details] [review] patch on master Here you go
Review of attachment 205968 [details] [review]: ::: clutter/x11/clutter-stage-x11.c @@ +502,3 @@ + /* We just created a window of the size of the actor. No need to fix + the size of the stage, just update it. */ this cannot be right. fix_window_size() is used to set the WMSizeHint, and that has nothing to do with the size of the actor.
Created attachment 205986 [details] [review] patch v3 Indeed, I can't test on master, and the function has changed on this bits. This patch is probably much better.
Review of attachment 205986 [details] [review]: I think we should move the xwin_width/height set near the cogl_onscreen_new() call instead of the end: it's semantically appropriate, and if we end up modifying realize in the future we don't end up risking adding functionality that depends on the size of the stage as stored by the ClutterStageX11 class. I pushed your patch with this minor changed to master.
Comment on attachment 204859 [details] [review] Patch v1 Pushed attachment 2048509 to the clutter-1.8 branch