After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667455 - caribou is broken for out-of-tree builds
caribou is broken for out-of-tree builds
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-07 05:29 UTC by Allison Karlitskaya (desrt)
Modified: 2012-11-02 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support out-of-tree build (2.07 KB, patch)
2012-10-22 06:26 UTC, Daiki Ueno 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-01-07 05:29:43 UTC 
i18n.py is generated from i18n.py.in and ends up in the builddir while the rest of the files stay in the srcdir.

this causes:

Traceback (most recent call last):

+ Trace 229402

  • File "/home/desrt/jhbuild/source/caribou/tools/make_schema.py", line 9 in <module> 
    from caribou.settings import caribou_settings
  • File "/home/desrt/jhbuild/source/caribou/caribou/__init__.py", line 1 in <module> 
    from i18n import _
ImportError: No module named i18n 






Comment 1


Daiki Ueno





          2012-10-22 06:26:00 UTC
        



Created attachment 226957 [details] [review]
Support out-of-tree build

Now that gettext is disabled when generating GSettings schemas (bug 686200), i18n.py is no longer necessary when building.  Thus we could support out-of-tree build by simply ignoring import errors.






Comment 2


Alejandro Piñeiro Iglesias (IRC: infapi00)





          2012-10-22 11:36:11 UTC
        



Review of attachment 226957 [details] [review]:

Look good to me






Comment 3


Daiki Ueno





          2012-10-23 00:29:25 UTC
        



Comment on attachment 226957 [details] [review]
Support out-of-tree build

Attachment 226957 [details] pushed as e45d12e - Support out-of-tree build






Comment 4


Rui Matos





          2012-11-02 09:26:09 UTC
        



So, this is fixed, right?