After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667447 - Missing many introspection annotations
Missing many introspection annotations
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-01-06 23:50 UTC by Evan Nemerson
Modified: 2012-01-11 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add lots of annotations for Vala bindings (23.26 KB, patch)
2012-01-06 23:52 UTC, Evan Nemerson
reviewed Details | Review
add lots of annotations for Vala bindings (23.39 KB, patch)
2012-01-07 18:04 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2012-01-06 23:50:47 UTC
I'm working on migrating the Vala bindings for GIO to GIR, and and there are a lot of conflicts between the current bindings and those generated from the GIR... many of them are better with GIR, but there are some regressions due to missing annotations.
Comment 1 Evan Nemerson 2012-01-06 23:52:34 UTC
Created attachment 204791 [details] [review]
add lots of annotations for Vala bindings

I don't think there is anything objectionable in here.
Comment 2 Colin Walters 2012-01-07 16:36:19 UTC
Review of attachment 204791 [details] [review]:

Two minor comments, otherwise looks good - thanks a lot for the patch!

::: gio/gdbusmessage.c
@@ +675,3 @@
  * Gets an array of all header fields on @message that are set.
  *
+ * Returns: (array): An array of header fields terminated by

Is this useful without zero-terminated=1?  Note G_DBUS_MESSAGE_HEADER_FIELD_INVALID should be 0.

::: gio/gmemoryinputstream.c
@@ +204,3 @@
 /**
  * g_memory_input_stream_new_from_data:
+ * @data: (array length=len) (element-type guint8) (transfer full): input data

Hmm...our support for transfer on input arguments is pretty weak in the stack.  But this makes sense to at least annotate.
Comment 3 Evan Nemerson 2012-01-07 18:04:24 UTC
Created attachment 204812 [details] [review]
add lots of annotations for Vala bindings

Adds zero-terminated=1 to g_dbus_message_get_header_fields. Everything else is unchanged.