GNOME Bugzilla – Bug 667447
Missing many introspection annotations
Last modified: 2012-01-11 20:59:56 UTC
I'm working on migrating the Vala bindings for GIO to GIR, and and there are a lot of conflicts between the current bindings and those generated from the GIR... many of them are better with GIR, but there are some regressions due to missing annotations.
Created attachment 204791 [details] [review] add lots of annotations for Vala bindings I don't think there is anything objectionable in here.
Review of attachment 204791 [details] [review]: Two minor comments, otherwise looks good - thanks a lot for the patch! ::: gio/gdbusmessage.c @@ +675,3 @@ * Gets an array of all header fields on @message that are set. * + * Returns: (array): An array of header fields terminated by Is this useful without zero-terminated=1? Note G_DBUS_MESSAGE_HEADER_FIELD_INVALID should be 0. ::: gio/gmemoryinputstream.c @@ +204,3 @@ /** * g_memory_input_stream_new_from_data: + * @data: (array length=len) (element-type guint8) (transfer full): input data Hmm...our support for transfer on input arguments is pretty weak in the stack. But this makes sense to at least annotate.
Created attachment 204812 [details] [review] add lots of annotations for Vala bindings Adds zero-terminated=1 to g_dbus_message_get_header_fields. Everything else is unchanged.