After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667435 - add shell menu
add shell menu
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-06 19:27 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clean-up open wizard from command line code (2.58 KB, patch)
2012-01-06 19:27 UTC, Marc-Andre Lureau 		committed Details | Review
add GtkApplication and shell menu (6.79 KB, patch)
2012-01-06 19:27 UTC, Marc-Andre Lureau 		committed Details | Review
add about dialog (2.25 KB, patch)
2012-01-06 19:28 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-01-06 19:27:54 UTC 
Add the shell menu, and a few actions
(the warnings from vala bindings have patches in review in bz)
Comment 1 Marc-Andre Lureau 2012-01-06 19:27:56 UTC 
Created attachment 204773 [details] [review]
Clean-up open wizard from command line code

This is a bit nicer to deal with, since we have only one constructor,
and is a bit more easy to read, also don't need to pass arguments via App.
Comment 2 Marc-Andre Lureau 2012-01-06 19:27:59 UTC 
Created attachment 204774 [details] [review]
add GtkApplication and shell menu
Comment 3 Marc-Andre Lureau 2012-01-06 19:28:01 UTC 
Created attachment 204775 [details] [review]
add about dialog
Comment 4 Zeeshan Ali 2012-01-06 22:15:49 UTC 
Review of attachment 204773 [details] [review]:

Cool!
Comment 5 Zeeshan Ali 2012-01-06 22:20:42 UTC 
Review of attachment 204774 [details] [review]:

Looks pretty good and teaches me new things. :) ACK once you've update gtk+ bindings:

app.vala:13.12-13.32: error: The type name `Gtk.ApplicationWindow' could not be
found
    public Gtk.ApplicationWindow window;
Comment 6 Zeeshan Ali 2012-01-06 22:26:30 UTC 
Review of attachment 204775 [details] [review]:

ACK!
Comment 7 Zeeshan Ali 2012-01-06 22:26:49 UTC 
Review of attachment 204775 [details] [review]:

ACK!
Comment 8 Marc-Andre Lureau 2012-01-06 22:40:57 UTC 
Attachment 204773 [details] pushed as c4aa53b - Clean-up open wizard from command line code
Attachment 204774 [details] pushed as 31d570b - add GtkApplication and shell menu
Attachment 204775 [details] pushed as 3cde8ef - add about dialog