After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667405 - sourcescanner compares file paths as case sensitive strings
sourcescanner compares file paths as case sensitive strings
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-06 12:15 UTC by jessevdk@gmail.com
Modified: 2015-02-07 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Compare filenames using g_file_equal() (2.83 KB, patch)
2012-04-09 15:25 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review

Description jessevdk@gmail.com 2012-01-06 12:15:58 UTC
The source scanner compares the file path of a symbol with known file paths to be scanned in a case sensitive manner by using simple strcmp on the file path string. On HFS+, paths are case insensitive by default (as well as on Windows I believe). In combination with python returning paths all in lower case (even if the path is in upper case, like /Users being returned as /users), the strcmp fails on OS X when comparing the paths.

One quick fix would be to use g_ascii_strcasecmp on OS X in the particular function. A better fix however is to properly use GFile instead of comparing strings.
Comment 1 Johan (not receiving bugmail) Dahlin 2012-04-09 15:25:25 UTC
Created attachment 211645 [details] [review]
Compare filenames using g_file_equal()

Makes it work on case-sensitive file systems such as HFS+.
Comment 2 Johan (not receiving bugmail) Dahlin 2012-04-09 15:25:44 UTC
Attachment 211645 [details] pushed as 47d4e95 - Compare filenames using g_file_equal()
Comment 3 André Klapper 2015-02-07 17:00:57 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]