After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667357 - configure.ac: wrong gtk2 dependency in git master breaks build on some platforms
configure.ac: wrong gtk2 dependency in git master breaks build on some platforms
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal trivial
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-05 13:47 UTC by Holger Kaelberer
Modified: 2012-01-06 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
increase gtk2 dependency from 2.14 to 2.24 (383 bytes, patch)
2012-01-05 13:47 UTC, Holger Kaelberer
none Details | Review

Description Holger Kaelberer 2012-01-05 13:47:11 UTC
Created attachment 204687 [details] [review]
increase gtk2 dependency from 2.14 to 2.24

gtk2 dependency in configure.ac is currently set to 
GTK2_REQ=2.14.0

which breaks building -bad on platforms with 2.14.0 < gtk2 < 2.24 as (at least) tests/examples/camerabin2/camerabin2.c presupposes 2.24.0:


CC     gst_camera2-gst-camera2.o
gst-camera2.c: In function 'init_gtkwidgets_data':
gst-camera2.c:264:3: error: 'GtkComboBoxText' undeclared (first use in this function)
gst-camera2.c:264:3: note: each undeclared identifier is reported only once for each function it appears in
gst-camera2.c:264:20: error: 'combobox' undeclared (first use in this function)
cc1: warnings being treated as errors
gst-camera2.c:265:7: error: implicit declaration of function 'GTK_COMBO_BOX_TEXT'
gst-camera2.c:265:7: error: nested extern declaration of 'GTK_COMBO_BOX_TEXT'
gst-camera2.c:270:5: error: implicit declaration of function 'gtk_combo_box_text_append_text'
gst-camera2.c:270:5: error: nested extern declaration of 'gtk_combo_box_text_append_text'
make[4]: *** [gst_camera2-gst-camera2.o] Error 1
make[4]: Leaving directory `/home/ralf/rpms/BUILD/gst-plugins-bad-0.10.22/tests/examples/camerabin2'


Also cf. the release notes on http://mail.gnome.org/archives/gtk-devel-list/2011-January/msg00042.html:

The attached patch fixes the issue.
Comment 1 Tim-Philipp Müller 2012-01-05 13:56:49 UTC
Is this with Vincent's patch from this morning?

commit 74952a15bf1db09711681cf7238981e03fd2608d
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Jan 5 11:01:01 2012 +0000

    tests: test for GTK 2.24 for new symbols used in camerabin2 tests
    
    The whole tree is likely to switch to GTK 3.0 at some point, but
    we might as well continue building with slightly less new versions
    if it's not hard to do.
Comment 2 Holger Kaelberer 2012-01-06 09:40:37 UTC
Oh, did not see that one.
Issue is resolved after git pull-ing the mentioned commit.
Sorry for the noise.