After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667339 - Source code relayout broke installation of score files
Source code relayout broke installation of score files
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnobots2
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-05 08:47 UTC by Vincent Untz
Modified: 2012-01-06 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnobots2: Fix creation of .scores files during build (2.29 KB, patch)
2012-01-05 09:00 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2012-01-05 08:47:17 UTC
The score files for gnobots2 are created in gnobots2/Makefile.am:

install-data-local:
        -$(mkinstalldirs) $(DESTDIR)$(scoredir)
        -for cfn in $(config_DATA); do \
            cfn2=`echo $$cfn | sed -e 's/\.cfg//'`; \
            fname1=$(DESTDIR)$(scoredir)/gnobots2.$$cfn2.scores; \
            fname2=$(DESTDIR)$(scoredir)/gnobots2.$$cfn2-safe.scores; \
            fname3=$(DESTDIR)$(scoredir)/gnobots2.$$cfn2-super-safe.scores; \
            touch $$fname1; chmod 664 $$fname1; chown $(scores_user):$(scores_group) $$fname1; \
            touch $$fname2; chmod 664 $$fname2; chown $(scores_user):$(scores_group) $$fname2; \
            touch $$fname3; chmod 664 $$fname3; chown $(scores_user):$(scores_group) $$fname3; \
            done

However, the config_DATA variable is now defined in gnobots2/data/Makefile.am, so this doesn't do anything anymore.
Comment 1 Vincent Untz 2012-01-05 09:00:23 UTC
Created attachment 204669 [details] [review]
gnobots2: Fix creation of .scores files during build
Comment 2 Robert Ancell 2012-01-05 21:59:19 UTC
Review of attachment 204669 [details] [review]:

Thanks Vincent!