After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667319 - GtkComboBoxText: allow id='' tag in builder markup
GtkComboBoxText: allow id='' tag in builder markup
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
unspecified
Other All
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 21:57 UTC by Allison Karlitskaya (desrt)
Modified: 2012-01-05 04:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkComboBoxText: allow id='' tag in builder markup (1.84 KB, patch)
2012-01-04 21:57 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-01-04 21:57:47 UTC 
Presently, GtkComboBoxText lets you list the items for it in the
GtkBuilder markup like so:

<items>
  <item translatable='yes'>Red</item>
  <item translatable='yes'>Blue</item>
</items>

but has no way to set the "id" column for added items.  Add an id='' tag
for that purpose so that you can do:

  <item id='red' translatable='yes'>Red</item>
Comment 1 Allison Karlitskaya (desrt) 2012-01-04 21:57:48 UTC 
Created attachment 204639 [details] [review]
GtkComboBoxText: allow id='' tag in builder markup
Comment 2 Matthias Clasen 2012-01-04 21:59:58 UTC 
Review of attachment 204639 [details] [review]:

Looks fine to me.
Comment 3 Allison Karlitskaya (desrt) 2012-01-04 22:00:45 UTC 
Attachment 204639 [details] pushed as 0ea48c4 - GtkComboBoxText: allow id='' tag in builder markup
Comment 4 Tristan Van Berkom 2012-01-05 04:15:33 UTC 
Great, I know we discussed this last year and I fell short of implementing
the 'id' in that format (actually the ids and the format extension landed
around the same time).

Opened this issue in Glade to track our side of the implementation: bug 667328.

Please feel free (but not harassed ;-)) to open issues on the Glade bug
list for any GtkBuilder format that is not yet supported (I think the
list is currently up to date though).