After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667311 - fix various unlikely, but still potential memoryleaks
fix various unlikely, but still potential memoryleaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 20:54 UTC by Håvard Graff (hgr)
Modified: 2012-01-05 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.33 KB, patch)
2012-01-04 20:54 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2012-01-04 20:54:22 UTC 
Created attachment 204629 [details] [review]
patch

.
Comment 1 Tim-Philipp Müller 2012-01-05 13:30:49 UTC 
Pushed, but without the gst_pb_utils_get_decoder_description() chunk. g_return_val_if_fail() is a courtesy to catch programming errors. The caller can be lucky we don't just crash in this case, and we will not take extra care to avoid leaks.
Comment 2 Tim-Philipp Müller 2012-01-05 13:31:35 UTC 
Comment on attachment 204629 [details] [review]
patch

commit 95be60de15801c8fec702672f9c1437298138e2f
Author: Havard Graff <havard.graff@tandberg.com>
Date:   Tue Nov 1 17:57:59 2011 +0100

    Fix various unlikely, but still potential memoryleaks in error code paths
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667311