After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667307 - build: Make sure AC_INCLUDES_DEFAULT is used.
build: Make sure AC_INCLUDES_DEFAULT is used.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 20:43 UTC by Håvard Graff (hgr)
Modified: 2012-05-16 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.04 KB, patch)
2012-01-04 20:44 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2012-01-04 20:43:27 UTC 
Without using AC_INCLUDES_DEFAULT explicitly,
ceratin platforms will complain that the header
was found, but not usable by the compiler.
This happens for instance on Solaris where certain
headers are needed to pull in proper defines.
Comment 1 Håvard Graff (hgr) 2012-01-04 20:44:21 UTC 
Created attachment 204625 [details] [review]
patch
Comment 2 Vincent Penquerc'h 2012-01-18 10:34:05 UTC 
Seems to have an unrelated (or non obviously related) chunk relating to the vorbis detection ?
Comment 3 Akhil Laddha 2012-03-06 05:47:15 UTC 
Håvard, ping, any response for comment#2 ?
Comment 4 Idar Tollefsen 2012-03-21 11:31:34 UTC 
I've been away on paternity leave. Apologies for the late answer.

Yes, it does indeed.

The chunk around the Vorbis detection is for autoconf 2.68 and newer which requires AC_LANG_SOURCE or AC_LANG_PROGRAM for AC_COMPILE_IFELSE. This should still work with older, relevant, versions of autoconf.

It got committed in the same chunk because I have 2.68 on Solaris and didn't see it there together with the AC_INCLUDES_DEFAULT fixes.

How do you want to proceed with it? Is it OK to have it in this patch, or do you want a separate "autoconf 2.68 upgrade" patch?
Comment 5 Tim-Philipp Müller 2012-05-16 08:47:37 UTC 
I've pushed the AC_INCLUDES_DEFAULT bits now.

I've omitted the AC_LANG_SOURCE bits, because the patch didn't apply any more and I added bits manually, and because I'm not sure if they're needed since there are AC_LANG_PROGRAM bits already and either one should be fine. My autoconf 2.68 doesn't complain anyway.


commit 443897bebc6169c9efc891220460240527cbc2d4
Author: Idar Tollefsen <itollefs@cisco.com>
Date:   Sun Jan 1 20:48:29 2012 +0100

    build: Make sure AC_INCLUDES_DEFAULT is used.
    
    Without using AC_INCLUDES_DEFAULT explicitly,
    certain platforms will complain that the header
    was found, but not usable by the compiler.
    This happens for instance on Solaris where certain
    headers are needed to pull in proper defines.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667307