After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667299 - basesrc: default return TRUE for latency-events reaching the src
basesrc: default return TRUE for latency-events reaching the src
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 20:05 UTC by Håvard Graff (hgr)
Modified: 2012-05-18 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (968 bytes, patch)
2012-01-04 20:05 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2012-01-04 20:05:02 UTC 
Created attachment 204617 [details] [review]
patch

The src is the final stop for this event, and the default result is FALSE
for all sources not implementing event handling, which again will result
in a warning about latency not being able to be configured.
Comment 1 Edward Hervey 2012-03-14 08:50:44 UTC 
I'd adjust that patch to only make it return TRUE by default for non-live sources. If it's a live source, the subclass must handle the query (even if it's just to return TRUE).
Comment 2 Wim Taymans 2012-05-18 08:16:22 UTC 
this was already fixed in 0.11, pushed your patch to 0.10 as well:

commit 57564ed276b4cc8b1acb6bf94328fe68c09974aa
Author: unknown <havard.graff@.eu.tandberg.int>
Date:   Tue Nov 8 12:04:38 2011 +0100

    basesrc: default return TRUE for latency-events reaching the src
    
    The src is the final stop for this event, and the default result is FALSE
    for all sources not implementing event handling, which again will result
    in a warning about latency not being able to be configured.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=667299
Comment 3 Wim Taymans 2012-05-18 08:16:57 UTC 
grmbl.. wrong author in the patch..