After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667295 - build: Run common platform check for platform specific configuration.
build: Run common platform check for platform specific configuration.
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 20:00 UTC by Håvard Graff (hgr)
Modified: 2012-05-16 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (595 bytes, patch)
2012-01-04 20:00 UTC, Håvard Graff (hgr) 		reviewed Details | Review

Description Håvard Graff (hgr) 2012-01-04 20:00:33 UTC 
Created attachment 204613 [details] [review]
patch

.
Comment 1 Tim-Philipp Müller 2012-01-05 01:09:07 UTC 
What does this actually fix in which environment? Better commit message please!

There's already an AG_GST_PLATFORM check in configure.ac (a bit below) - maybe it should just be moved? (Or maybe this patch was filed against the wrong module?)
Comment 2 Akhil Laddha 2012-02-22 11:48:06 UTC 
Håvard, ping, could you please respond to comment#1 ?
Comment 3 Idar Tollefsen 2012-05-15 13:59:48 UTC 
Firstly, yes, it should be a move. I must have missed the other one.

Secondly, this doesn't make sense without the changes I did to AG_GST_PLATFORM in common, which I see didn't get submitted.

I was working on Solaris/SunPro support and added XPG6 w/extension checks/setup to its own file and incorporated that into AG_GST_PLATFORM, which then should be run as early as possible to take effect for later configure checks.

I can either re-work this so that it moves it instead of adding another one, which would lay the groundwork for the changes to common, or this can be closed now and I'll resubmit it when we also submit the common changes.
Comment 4 Tim-Philipp Müller 2012-05-16 07:22:15 UTC 
I'm happy to just move it if it helps with anything, but if it only makes sense in connection with other changes in common/AG_GST_PLATFORM, I'd prefer to commit both together.

So closing until the platform check changes are ready too I guess.