GNOME Bugzilla – Bug 667287
gstpad: Cast function pointer assigments to lhs type (gpointer)
Last modified: 2012-07-09 08:40:11 UTC
Created attachment 204604 [details] [review] patch .
This looks fine, but why is it needed exactly? Anything can be assigned to void* without problems usually (in C anyway).
Håvard, ping, could you please respond to comment#1 ?
(In reply to comment #1) > This looks fine, but why is it needed exactly? Anything can be assigned to > void* without problems usually (in C anyway). Indeed, but some compilers will issue a warning about the implicit casts. In this case, it was the SunPro compiler on Solaris. For other compilers, it's probably a matter of how high you set the warning level.
Hrm, ok. So I acknowledge that there's a minor issue here, but I think I'm just going to WONTFIX this at this point, since it's 0.10 specific, and I don't think the patch actually makes the code better in any way. It would probably have to be solved in a slightly more convoluted way, but that also isn't really particularly interesting for 0.10 at this point IMHO.