After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667284 - registry: add missing #ifndef guard
registry: add missing #ifndef guard
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 19:46 UTC by Håvard Graff (hgr)
Modified: 2012-02-04 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (883 bytes, patch)
2012-01-04 19:46 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2012-01-04 19:46:59 UTC 
Created attachment 204600 [details] [review]
patch

__registry_reuse_plugin_scanner is only defined when GST_DISABLE_REGISTRY is not
Comment 1 Tim-Philipp Müller 2012-01-04 23:25:32 UTC 
This looks formally correct, but as I see it none of the surrounding code should be compiled either if GST_DISABLE_REGISTRY is defined. (Out of curiosity: are you guys using this, or is this patch the result of a source code validation tool of some sort?)
Comment 2 Håvard Graff (hgr) 2012-01-05 08:22:37 UTC 
That one was simply a case of GST_DISABLE_REGISTRY being defined for Android and iOS builds, and then failing to compile because that was not defined.
Comment 3 Tim-Philipp Müller 2012-02-04 15:53:21 UTC 
Fair enough. I think there's more to do here, but it fixes the build, so let's put it in. Thanks for the patch!

commit 609e618e70bf51bab6fe970b1774da8d1a8f8719
Author: Havard Graff <havard.graff@tandberg.com>
Date:   Wed Jan 4 17:10:15 2012 +0100

    registry: fix compilation with --disable-registry
    
    __registry_reuse_plugin_scanner is only defined when
    GST_DISABLE_REGISTRY is not defined.
    
    gstregistry.c: In function 'gst_registry_scan_plugin_file':
    gstregistry.c:1131:8: error: '__registry_reuse_plugin_scanner' undeclared (first use in this function)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667284