After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667221 - dvdspu: some optimizations
dvdspu: some optimizations
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-03 21:53 UTC by Rob Clark
Modified: 2015-08-28 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvdspu: some optimizations (8.15 KB, patch)
2012-01-03 21:54 UTC, Rob Clark 		none Details | Review
dvdspu: some optimizations (5.81 KB, patch)
2015-02-07 19:18 UTC, Jan Schmidt 		committed Details | Review

Description Rob Clark 2012-01-03 21:53:40 UTC 
Detect invisible pixels, and skip gstspu_vobsub_blend_comp_buffers()
when there are only invisible pixels.  This significantly reduces the
CPU load in cases of DVDs which don't use the clip_rect to exclude
processing for parts of the screen where the video is visible.

patch attached
Comment 1 Rob Clark 2012-01-03 21:54:05 UTC 
Created attachment 204528 [details] [review]
dvdspu: some optimizations
Comment 2 Jan Schmidt 2012-10-02 16:20:17 UTC 
Review of attachment 204528 [details] [review]:

The parts of this patch that assume a pixel is invisible if Y U & V are all 0 seem bogus. 0/0/0 is a valid YUV colour: Bright green. A pixel is only invisible if the Alpha is 0. Otherwise, it seems useful to avoid blending completely invisible pixel rows.
Comment 3 Jan Schmidt 2015-02-07 19:18:44 UTC 
Created attachment 296347 [details] [review]
dvdspu: some optimizations

Detect invisible pixels, and skip gstspu_vobsub_blend_comp_buffers()
when there are only invisible pixels.  This significantly reduces the
CPU load in cases of DVDs which don't use the clip_rect to exclude
processing for parts of the screen where the video is visible.
Comment 4 Jan Schmidt 2015-02-07 19:19:47 UTC 
Comment on attachment 296347 [details] [review]
dvdspu: some optimizations

Removed the parts that assume Y=U=V==0 means invisible and pushing the rest.