After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667219 - videoparsers: fix mpeg2 parsing confusion w/ dvd
videoparsers: fix mpeg2 parsing confusion w/ dvd
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-03 21:48 UTC by Rob Clark
Modified: 2012-01-31 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoparsers: fix mpeg2 parsing confusion w/ dvd (1.33 KB, patch)
2012-01-03 21:48 UTC, Rob Clark 		none Details | Review

Description Rob Clark 2012-01-03 21:48:20 UTC 
Perhaps not unique to mpeg2 from DVD, but this is the case where I'm
seeing the parsing logic tripped up by an extension_start_code which
is not sequence_extension_id.

patch attached
Comment 1 Rob Clark 2012-01-03 21:48:43 UTC 
Created attachment 204526 [details] [review]
videoparsers: fix mpeg2 parsing confusion w/ dvd
Comment 2 Vincent Penquerc'h 2012-01-31 12:07:48 UTC 
I can't seem to be able to find the file your patch patches. Is this one of your own files by any chance ?
Grepping around for some of the context in the patch comes up empty, so not something that's moved files either...
Some parers were ported to a new parser lib, so chances are the code you're patching is entirely gone. If you find the bug is still there under another guise, please reopen with a patch for the new code.
Comment 3 Tim-Philipp Müller 2012-01-31 12:39:00 UTC 
Looks this is indeed handled now:

in gst-libs/gst/codecparsers/gstmpegvideoparse.c:

408)   if (gst_bit_reader_get_bits_uint8_unchecked (&br, 4) !=
409)       GST_MPEG_VIDEO_PACKET_EXT_SEQUENCE) {
410)     GST_DEBUG ("Not parsing a sequence extension");
411)     return FALSE;
412)   }