GNOME Bugzilla – Bug 667070
gmime-2.4.x and 2.6.x rely on db2html instead of docbook2html
Last modified: 2012-01-27 01:40:02 UTC
On Gentoo, we are carrying for ages the following change: # db2html should be docbook2html sed -i -e 's:db2html:docbook2html:' \ configure.ac configure || die "sed failed (1)" sed -i -e 's:db2html:docbook2html -o gmime-tut:g' \ docs/tutorial/Makefile.am docs/tutorial/Makefile.in \ || die "sed failed (2)" This is needed because docbook-sgml-utils provided by http://sources.redhat.com/docbook-tools/ doesn't contain db2html. Looks like fedora is providing their own db2html, but looking to other distributions like opensuse seems that they are doing the same as us on Gentoo: rely on docbook-tools upstream provided tools Thanks
Proper thing to do here would most likely be to use AC_CHECK_PROG([DB2HTML], [db2html docbook2html], ...) and use the $(DB2HTML) variable in Makefile.am.
ok I just checked that our package does not provide db2pdf equivalent. Is this supposed to be shipped in the tarball itself btw ?
I got docbook2pdf from docbook-utils package in OpenSUSE, not sure where it comes from other than that :-\ Fixed the configure checks and tutorial makefiles in both gmime-2.4 and 2.6 branches. will be making a new release with these fixes today.
Sadly, looks like it still fails to detect it properly, I see the following in configure: checking for docbook2html... /usr/bin/docbook2html Usage: jw [<options>] <sgml_file> where <options> are: -f|--frontend <frontend>: Specify the frontend (source format) (default is docbook) -b|--backend <backend>: Specify the backend (destination format) (default is html) -c|--cat <file>: Specify an extra SGML open catalog -n|--nostd: Do not use the standard SGML open catalogs -d|--dsl <file>|default|none: Specify an alternate style sheet (default is to use the default stylesheet) -l|--dcl <file>: Specify an alternate SGML declaration (usual ones like xml.dcl get detected automatically) -s|--sgmlbase <path>: Change base directory for SGML distribution (usually /usr/share/sgml) -p|--parser <program>: Specify the parser if several are installed (jade or openjade) -o|--output <directory>: Set output directory -u|--nochunks: Output only one big file (overrides the stylesheet settings) -i|--include <section>: Specify a SGML marked section to include (should be marked as "ignore" in the SGML text) -w|--warning <warning_type>|list: Control warnings or display the allowed warning types -e|--errors <error_type>|list: Control errors or display the allowed error types -h|--help: Print this help message and exit -V <variable[=value]>: Set a variable -v|--version: Print the version and exit checking for x86_64-pc-linux-gnu-pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.16... yes And, looking to build.log, I can see tutorial is not being built: make -j5 -C docs/tutorial html make: Entering directory `/var/tmp/portage/dev-libs/gmime-2.4.31/work/gmime-2.4.31/docs/tutorial' echo "***" *** echo "*** Warning: Tutorial not built" *** Warning: Tutorial not built echo "***" *** make: Leaving directory `/var/tmp/portage/dev-libs/gmime-2.4.31/work/gmime-2.4.31/docs/tutorial' You will also see that, until now, we need to manually run: make -C docs/tutorial html To get them build, otherwise are skipped, but this is an old problem :(
Created attachment 205037 [details] config.log
Created attachment 205038 [details] Full build.log
Created attachment 205686 [details] [review] Proposed patch (for master branch) (In reply to comment #4) Right. DB2HTML is now a path to a tool, not just "true"/"false", so in AM_CONDITIONAL we need to test it for non-emptiness instead of trying to execute it. Also, docbook2html uses . as the default output directory, while Fedora's db2html uses gmime-tut by default. Therefore, when calling $DB2HTML we need to explicitly specify the output directory ("-o html").
Created attachment 205687 [details] [review] Proposed patch (for 2.4 branch)
Incidentally, if you want to test Fedora's db2html, you can find it at http://pkgs.fedoraproject.org/gitweb/?p=docbook-utils.git;a=blob;f=db2html
Applied in git, thanks!