After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667030 - Add a --version argument
Add a --version argument
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Patricia Santana Cruz
nautilus-sendto-maint
Depends on:
Blocks: 522210
 
 
Reported: 2011-12-30 14:29 UTC by Patricia Santana Cruz
Modified: 2012-01-06 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add --version argument. (1.87 KB, patch)
2011-12-30 17:33 UTC, Patricia Santana Cruz 		accepted-commit_now Details | Review
Updated patch based on review in comment https://bugzilla.gnome.org/show_bug.cgi?id=667030#c2 (1.53 KB, patch)
2012-01-02 10:46 UTC, Patricia Santana Cruz 		accepted-commit_now Details | Review
Updated patch based on review in comment https://bugzilla.gnome.org/show_bug.cgi?id=667030#c4 (1.57 KB, patch)
2012-01-03 11:15 UTC, Patricia Santana Cruz 		committed Details | Review

Description Patricia Santana Cruz 2011-12-30 14:29:51 UTC 
Would be nice to have a --version argument. This could be used for instance by other programs that are using nautilus-sendto at run time and need to check the dependency.
Comment 1 Patricia Santana Cruz 2011-12-30 17:33:28 UTC 
Created attachment 204352 [details] [review]
Add --version argument.

This patch fixes the bug.
Comment 2 Bastien Nocera 2011-12-30 23:50:57 UTC 
Review of attachment 204352 [details] [review]:

Fine to commit without the other whitespace changes.

::: src/nautilus-sendto-command.c
@@ +54,3 @@
 static gboolean run_from_build_dir = FALSE;
 static gint64 xid = 0;
+static gboolean version = FALSE;

show_version instead, maybe.
Comment 3 Patricia Santana Cruz 2012-01-02 10:46:52 UTC 
Created attachment 204445 [details] [review]
Updated patch based on review in comment https://bugzilla.gnome.org/show_bug.cgi?id=667030#c2
Comment 4 Bastien Nocera 2012-01-02 11:25:47 UTC 
Review of attachment 204445 [details] [review]:

I would just put the bug URL in the commit message (rather than "fixes bug..."), means the link is clickable when reading the logs.
Comment 5 Patricia Santana Cruz 2012-01-03 11:15:15 UTC 
Created attachment 204489 [details] [review]
Updated patch based on review in comment https://bugzilla.gnome.org/show_bug.cgi?id=667030#c4