After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666984 - Please review focus grabbing/key binding patch (Inkscape)
Please review focus grabbing/key binding patch (Inkscape)
Product: gdl
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Blocks: 652248
Reported: 2011-12-29 13:23 UTC by Alex Valavanis
Modified: 2012-02-26 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add focus handling and key bindings (Inkscape) (10.40 KB, patch)
2011-12-29 13:23 UTC, Alex Valavanis
reviewed Details | Review
Add focus handling and key bindings (Inkscape) (12.73 KB, patch)
2012-01-01 16:29 UTC, Alex Valavanis
accepted-commit_now Details | Review

Description Alex Valavanis 2011-12-29 13:23:14 UTC
Created attachment 204315 [details] [review]
Add focus handling and key bindings (Inkscape)

Here is the focus grabbing/key binding patch from Inkscape.  It adds the following functions to gdl-dock-items:

gdl_dock_item_set_focus_child(...) - Set focus on the specified child widget

gdl_dock_item_move_focus_child(...) - Move focus on the next child widget in a given direction

gdl_dock_item_or_child_has_focus(...) - Check whether the specified dock item or any of its children (recursively!) has focus.

It also implements tab and arrow-key bindings, and moves focus accordingly.
Comment 1 Johannes Schmid 2011-12-30 16:56:45 UTC
Review of attachment 204315 [details] [review]:

Overall I think that is correct. Could you give some more explanation how the changes affect gdl, e.g. add a bit more info to the commit message?
Comment 2 Alex Valavanis 2012-01-01 16:29:23 UTC
Created attachment 204419 [details] [review]
Add focus handling and key bindings (Inkscape)

Added a more verbose comment to the commit, and provided GTK-Doc comments for the new ::move-focus-child signal and the new public gtk_dock_item_or_child_has_focus method.
Comment 3 Johannes Schmid 2012-02-02 13:40:25 UTC
Review of attachment 204419 [details] [review]:

Sorry for the late review, I kind of remember the other bug with the missing property handling but missed this one.  Looks good now. Thanks!
Comment 4 Alex Valavanis 2012-02-25 16:54:42 UTC
Hi Johannes,

Is there anything left to do here, or are we OK to go ahead with the merge?
Comment 5 Johannes Schmid 2012-02-26 11:37:10 UTC
Sorry, I thought I had merged this already...