GNOME Bugzilla – Bug 666969
Please review Pixbuf icon patch (Inkscape)
Last modified: 2012-01-01 13:14:46 UTC
Created attachment 204307 [details] [review]
Pixbuf icon patch
Here's one of the patches from Inkscape... it allows creation of dock items with a pixbuf icon using
This is the only API change that is needed to allow Inkscape to link against external gdl, and hopefully it should be of some use to other projects.
I'll submit separate reports for other functionality changes introduced in our fork.
Review of attachment 204307 [details] [review]:
Thanks! That looks good!
I know that there are none for the old methods, but could you please add gtk-doc comments for the new public methods and (if possible) for the public methods you changed.
Sure. I'll take care of it tomorrow, hopefully.
Created attachment 204404 [details] [review]
Additional patch to add GTK-Doc comments
Here are some comments as requested. I'm completely new to GTK-Doc, so please check my work carefully!
Review of attachment 204404 [details] [review]: