After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666969 - Please review Pixbuf icon patch (Inkscape)
Please review Pixbuf icon patch (Inkscape)
Product: gdl
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Reported: 2011-12-29 00:27 UTC by Alex Valavanis
Modified: 2012-01-01 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Pixbuf icon patch (12.30 KB, patch)
2011-12-29 00:27 UTC, Alex Valavanis
reviewed Details | Review
Additional patch to add GTK-Doc comments (18.96 KB, patch)
2012-01-01 02:51 UTC, Alex Valavanis
accepted-commit_now Details | Review

Description Alex Valavanis 2011-12-29 00:27:40 UTC
Created attachment 204307 [details] [review]
Pixbuf icon patch

Here's one of the patches from Inkscape... it allows creation of dock items with a pixbuf icon using

gdl_dock_item_new_with_pixbuf_icon (...)

This is the only API change that is needed to allow Inkscape to link against external gdl, and hopefully it should be of some use to other projects.

I'll submit separate reports for other functionality changes introduced in our fork.
Comment 1 Johannes Schmid 2011-12-30 16:54:55 UTC
Review of attachment 204307 [details] [review]:

Thanks! That looks good!

I know that there are none for the old methods, but could you please add gtk-doc comments for the new public methods and (if possible) for the public methods you changed.
Comment 2 Alex Valavanis 2011-12-30 19:50:56 UTC
Sure.  I'll take care of it tomorrow, hopefully.
Comment 3 Alex Valavanis 2012-01-01 02:51:12 UTC
Created attachment 204404 [details] [review]
Additional patch to add GTK-Doc comments

Here are some comments as requested.  I'm completely new to GTK-Doc, so please check my work carefully!
Comment 4 Johannes Schmid 2012-01-01 13:07:03 UTC
Review of attachment 204404 [details] [review]:

Perfekt! Thanks!