After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666932 - support "Vendor" option in nm-connection-editor
support "Vendor" option in nm-connection-editor
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: vpnc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2011-12-28 03:49 UTC by Ildar
Modified: 2012-02-28 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Add 'Vendor' and 'Perfect Forward Secrecy' into GUI (12.86 KB, patch)
2012-02-27 09:09 UTC, Jiri Klimes
none Details | Review
screenshot with added options (44.44 KB, image/png)
2012-02-27 09:12 UTC, Jiri Klimes
  Details

Description Ildar 2011-12-28 03:49:36 UTC
Having workaround:
Do it by hands puting this (e.g.):
 Vendor=netscreen
to the [vpn] section in the connection file at /etc/NetworkManager/system-connections
Comment 1 Ildar 2011-12-29 07:12:33 UTC
also need to add this:
Perfect Forward Secrecy dh2
Comment 2 Jiri Klimes 2012-02-27 09:09:13 UTC
Created attachment 208471 [details] [review]
[PATCH] Add 'Vendor' and 'Perfect Forward Secrecy' into GUI
Comment 3 Jiri Klimes 2012-02-27 09:12:26 UTC
Created attachment 208472 [details]
screenshot with added options

The two options added as combo boxes into 'Advanced Options' dialog.
Comment 4 Dan Williams 2012-02-27 16:06:52 UTC
I'd suggest changing the "No PFS" text in the combo to "None" instead.

Originally I'd wanted to do this on a higher level and have plugins be able to export multiple "personalities" so that, for example, when you click "New..." in the VPN page of the editor and it asks you what type of VPN you want to create, my though had been to allow VPN plugins to provide multiple items in that combo box.  Thus the vpnc plugin would provide "Cisco-compatible IPSec" and "Juniper/Netscreen-compatible IPSec" or whatever, and that would somehow get passed to the plugin.  But that's something that we'd either have to hack into the current API in a somewhat ugly way, or rework the API.

So I think what you've got here is good to commit, thanks!
Comment 5 Jiri Klimes 2012-02-28 09:50:22 UTC
Ok, "No PFS" changed to "None" and committed:
14733a43a15bba3861f585872986cff4c5136bee
Comment 6 Ildar 2012-02-28 10:12:12 UTC
thanks