GNOME Bugzilla – Bug 666819
Last modified: 2012-08-29 02:50:31 UTC
Created attachment 220645 [details] [review]
Patch which tries adding GtkApplication and application menu support.
I made an attempt to use GtkApplication and move the menubar to application menu. This is the first time I send a patch to a free software project, so I hope I don't do that completely wrong :) (More details in the commit message)
Review of attachment 220645 [details] [review]:
Thanks for this! The limitiations you've pointed out I think also apply to other applications, so I don't see this as blocking this patch being committed. The code looks good, I've comitted with one change - adding a "gtali: " to the commit message.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Embedding XML code in C file makes menu entries not translatable. Please follow other games approach.
Elizabeth, could you make an additional patch that does what Piotr has asker for? Thanks.
Created attachment 221467 [details] [review]
Separate xml file for application menu
This should do the job.
Review of attachment 221467 [details] [review]:
Thanks for this but it didn't have the code to load it. I've updated master now to have translatable entries.