After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666819 - Use GtkApplication
Use GtkApplication
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gtali
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-24 23:26 UTC by Robert Ancell
Modified: 2012-08-29 02:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch which tries adding GtkApplication and application menu support. (8.96 KB, patch)
2012-08-08 08:39 UTC, ElizabethHenry
committed Details | Review
Separate xml file for application menu (2.10 KB, patch)
2012-08-16 20:28 UTC, ElizabethHenry
rejected Details | Review

Description Robert Ancell 2011-12-24 23:26:55 UTC
Use GtkApplication
Comment 1 ElizabethHenry 2012-08-08 08:39:42 UTC
Created attachment 220645 [details] [review]
Patch which tries adding GtkApplication and application menu support.

I made an attempt to use GtkApplication and move the menubar to application menu. This is the first time I send a patch to a free software project, so I hope I don't do that completely wrong :) (More details in the commit message)
Comment 2 Robert Ancell 2012-08-13 00:37:34 UTC
Review of attachment 220645 [details] [review]:

Thanks for this! The limitiations you've pointed out I think also apply to other applications, so I don't see this as blocking this patch being committed. The code looks good, I've comitted with one change - adding a "gtali: " to the commit message.
Comment 3 Robert Ancell 2012-08-13 00:37:53 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Piotr Drąg 2012-08-14 22:22:58 UTC
Embedding XML code in C file makes menu entries not translatable. Please follow other games approach.
Comment 5 Robert Ancell 2012-08-14 23:00:19 UTC
Elizabeth, could you make an additional patch that does what Piotr has asker for? Thanks.
Comment 6 ElizabethHenry 2012-08-16 20:28:56 UTC
Created attachment 221467 [details] [review]
Separate xml file for application menu

Hi,

This should do the job.
Comment 7 Robert Ancell 2012-08-29 02:50:00 UTC
Review of attachment 221467 [details] [review]:

Thanks for this but it didn't have the code to load it. I've updated master now to have translatable entries.
Comment 8 Robert Ancell 2012-08-29 02:50:31 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.