After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666773 - Untranslated strings in the audioscrobbler plugin
Untranslated strings in the audioscrobbler plugin
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: last.fm
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-23 19:37 UTC by Gabor Kelemen
Modified: 2012-01-07 07:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the problem (244.47 KB, image/png)
2011-12-23 19:37 UTC, Gabor Kelemen
  Details
Call gettext() when needed (2.53 KB, patch)
2011-12-23 19:39 UTC, Gabor Kelemen
committed Details | Review

Description Gabor Kelemen 2011-12-23 19:37:50 UTC
Created attachment 204149 [details]
Screenshot of the problem

There are several strings in the audioscrobbler plugin, which appear untranslated, see screenshot.
- In the side bar, the various radio names, like Rhythmbox Group Radio or $Artist Fan Radio, $Artist Radio
- The items in the Type: dropdown under Create Radio Station
- Menu items of the tracks under Recently Listened Tracks

The first two happens because the strings are in a static array and the gettext() function is not called when they are used. Last one happens because the two strings are not marked for translation.
Comment 1 Gabor Kelemen 2011-12-23 19:39:50 UTC
Created attachment 204150 [details] [review]
Call gettext() when needed

This should do the trick, but I cannot currently compile rb to double check.
Comment 2 Jonathan Matthew 2012-01-07 07:39:12 UTC
pushed (with rearranged commit message) as commit 75498df, thanks.