After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666769 - network-manager-pptp always saves (OTP) password in keyring
network-manager-pptp always saves (OTP) password in keyring
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: pptp
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-23 17:21 UTC by Han Pilmeyer
Modified: 2016-03-20 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Han Pilmeyer 2011-12-23 17:21:49 UTC
I need to authenticate using a one time password device to a PPTP VPN gateway. This used to work fine before Ubuntu 11.10 (i.e. before network-manager-pptp 0.9.0). For instance with Ubuntu 11.04 (using network-manager-pptp-0.8.1+git.20110207t142407.7e1d989), I would be prompted for my password when starting the PPTP connection, I would enter the password generated by my OTP device and I would NOT tick the "Save passwords in keyring" box.

However with the 0.9.0 version of network-manager-pptp this option no longer exists, so it will only work once. A new attempt to start the VPN will use the password stored in the keyring, which will of course not work. This means I have to manually remove the password from the keyring.

This change was introduce with the following commit:

commit 48a7dee3e950d84be497cf726fad50a17555bf5e
Author: Dan Williams <dcbw redhat com>
Date:   Mon Jul 18 11:40:03 2011 -0500

    auth-dialog: use a simplified password request dialog
    
    Strip out all the stuff we don't care about (mainly the keyring
    remember stuff).

The same change was also made in the openvpn equivalent, but there it was also changed to make changing the password a permanent option, i.e. choosing between "Saved", "Always ask" and "Not required". This was done in the following commit to network-manager-openvpn:

commit 0f4daf4570f1777c84040053299fa8adb636bf74
Author: Dan Williams <dcbw redhat com>
Date:   Wed Jul 13 21:53:29 2011 -0500

    properties: add password type combo (saved, ask, not required)
    
    Like vpnc has; they map directly to the NM internal secret flags and
    allows better support for user preference or one-time-pad tokens.

Please also make the equivalent change to the PPTP VPN.
Feel free to contact me for more information or testing of the possible changes.
Comment 1 esleggiero 2013-12-18 22:35:48 UTC
The same problem occurs in the Ubuntu 13.10.
Comment 2 Lubomir Rintel 2016-03-20 16:00:27 UTC
I believe this was fixed at this point:
https://git.gnome.org/browse/network-manager-pptp/commit/?id=8d3448d6d0b4863974d4a16ee85ec0bf28d5b6a7

Please reopen if the problem persists. Sorry you didn't hear from us for that long.