After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666608 - missing messages in POT/PO files
missing messages in POT/PO files
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Internationalisation
2.7.4
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2011-12-20 18:15 UTC by OKANO Takayoshi
Modified: 2011-12-22 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a patch for this bug (891 bytes, patch)
2011-12-21 15:14 UTC, Jiro Matsuzawa
accepted-commit_now Details | Review

Description OKANO Takayoshi 2011-12-20 18:15:59 UTC
In POT file distributed at damned-lies (http://l10n.gnome.org/POT/gimp.master/gimp-plug-ins.master.pot),
messages from plug-ins/ui/* are missing.

So these messages were lost in merged PO files.

e.g.
plug-ins/ui/plug-in-file-png.ui:
>         <property name="label" translatable="yes">_Interlacing (Adam7)</property>

This message is used in the dialog for exporting PNG file,
but not appear in POT file.
and in po-plug-ins/ja.po, it is commented out treated as obsolete one.
> #~ msgid "_Interlacing (Adam7)"
Comment 1 Jiro Matsuzawa 2011-12-21 15:14:17 UTC
Created attachment 204042 [details] [review]
a patch for this bug

It seems that the lines of *.ui in POTFILE.in are wrong.
I wrote a patch.
Please review it.

Thanks,
Comment 2 OKANO Takayoshi 2011-12-22 02:07:51 UTC
I applied this patch and make POT file via intltool.
It looks file.

Thank you.
Comment 3 Michael Natterer 2011-12-22 12:27:40 UTC
I've never seen this [type: foo/bar] feature, since when is it in intltool?
Can we just use it with our minimum version of 0.40.1?
Comment 4 Claude Paroz 2011-12-22 12:31:39 UTC
Comment on attachment 204042 [details] [review]
a patch for this bug

This is fine, thanks
Comment 5 Claude Paroz 2011-12-22 12:33:31 UTC
(In reply to comment #3)
> I've never seen this [type: foo/bar] feature, since when is it in intltool?
> Can we just use it with our minimum version of 0.40.1?

This is in intltool from long ago. See https://bugs.launchpad.net/intltool/+bug/381347 for the rationale about this prefix.
Comment 6 Michael Natterer 2011-12-22 12:41:09 UTC
Great, please push then.
Comment 7 Jiro Matsuzawa 2011-12-22 12:43:51 UTC
OK, I'll push.

Thank you,
Comment 8 Jiro Matsuzawa 2011-12-22 12:48:38 UTC
I've pushed it.
http://git.gnome.org/browse/gimp/commit/?id=f1d31f244bad583a4c78bd5edcb2eb713b18c8e9

Thank you,
Comment 9 OKANO Takayoshi 2011-12-22 12:59:49 UTC
I confirmed pot file can be made appropriately.

Thank you very much.