After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666552 - Layered region is leaked in GdkWindow
Layered region is leaked in GdkWindow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-12-19 18:26 UTC by Xan Lopez
Modified: 2011-12-19 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Free layered region (2.07 KB, patch)
2011-12-19 18:26 UTC, Xan Lopez 		accepted-commit_now Details | Review
gdkwindow: plug memory leak (2.12 KB, patch)
2011-12-19 20:06 UTC, Matthias Clasen 		committed Details | Review
Updates (2.21 KB, patch)
2011-12-19 20:06 UTC, Matthias Clasen 		committed Details | Review

Description Xan Lopez 2011-12-19 18:26:29 UTC 
Created attachment 203907 [details] [review]
Free layered region

Spotted by Valgrind. Proposal to free it in finalize attached.
Comment 1 Matthias Clasen 2011-12-19 19:45:12 UTC 
Review of attachment 203907 [details] [review]:

Looks good
Comment 2 Matthias Clasen 2011-12-19 20:06:30 UTC 
The following fixes have been pushed:
2d70d8f gdkwindow: plug memory leak
8eb58a6 Updates
Comment 3 Matthias Clasen 2011-12-19 20:06:35 UTC 
Created attachment 203912 [details] [review]
gdkwindow: plug memory leak

==23282== 64 bytes in 2 blocks are definitely lost in loss record 8,069 of 13,389
==23282==    at 0x4A074CD: malloc (vg_replace_malloc.c:236)
==23282==    by 0x39A1C3E2EA: cairo_region_create (cairo-region.c:196)
==23282==    by 0x6D9AF3D: recompute_visible_regions_internal (gdkwindow.c:964)
==23282==    by 0x6D9B4B8: recompute_visible_regions (gdkwindow.c:1126)
==23282==    by 0x6DA3450: gdk_window_hide (gdkwindow.c:5689)
==23282==    by 0x6D9CED9: _gdk_window_destroy_hierarchy (gdkwindow.c:2042)
==23282==    by 0x6D9D040: gdk_window_destroy (gdkwindow.c:2109)
==23282==    by 0x655B5E4: gtk_entry_unrealize (gtkentry.c:3012)
==23282==    by 0x7068BF3: g_cclosure_marshal_VOID__VOID (gmarshal.c:85)
==23282==    by 0x706710B: g_type_class_meta_marshal (gclosure.c:885)
==23282==    by 0x7066DF9: g_closure_invoke (gclosure.c:774)
==23282==    by 0x7080585: signal_emit_unlocked_R (gsignal.c:3340)
==23282==    by 0x707F619: g_signal_emit_valist (gsignal.c:3033)
==23282==    by 0x707FB71: g_signal_emit (gsignal.c:3090)
==23282==    by 0x679E243: gtk_widget_unrealize (gtkwidget.c:4458)
==23282==    by 0x64E83C7: gtk_bin_forall (gtkbin.c:172)
==23282==    by 0x6548BBD: gtk_container_forall (gtkcontainer.c:2014)
==23282==    by 0x67A966D: gtk_widget_real_unrealize (gtkwidget.c:10253)
==23282==    by 0x672D002: gtk_tool_item_unrealize (gtktoolitem.c:474)
==23282==    by 0x7068BF3: g_cclosure_marshal_VOID__VOID (gmarshal.c:85)
Comment 4 Matthias Clasen 2011-12-19 20:06:44 UTC 
Created attachment 203913 [details] [review]
Updates