After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666542 - Visual Magnifier Blue Foreground Yellow Background color filter
Visual Magnifier Blue Foreground Yellow Background color filter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-19 16:30 UTC by David <Biomech360>
Modified: 2012-01-06 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch file generated by git format-patch -n1 (4.79 KB, patch)
2011-12-19 16:30 UTC, David <Biomech360> 		committed Details | Review
Resending of the proposed patch (845 bytes, patch)
2011-12-19 17:18 UTC, David <Biomech360> 		committed Details | Review

Description David <Biomech360> 2011-12-19 16:30:33 UTC 
Created attachment 203889 [details] [review]
The patch file generated by git format-patch -n1

This change is meant to provide support for a high contrast color filter that used under gnome-video-effects.

This filter in gst-plugins-bad/gst/coloreffects/ is meant to be used in concert with other pipelines to make it a high contrast image.

This modification was developed and tested on a stable .10.x build of gst-plugins-bad.
Comment 1 Vincent Penquerc'h 2011-12-19 16:36:05 UTC 
Review of attachment 203889 [details] [review]:

::: gst/coloreffects/gstcoloreffects.c
@@ +582,1 @@
         default:

Missing break.
Comment 2 David <Biomech360> 2011-12-19 17:18:02 UTC 
Created attachment 203899 [details] [review]
Resending of the proposed patch

Did not copy over a break statement (as mentioned).
Break statement has been added.
Comment 3 Vincent Penquerc'h 2012-01-06 11:27:23 UTC 
Thanks, pushed (both patches merged, and with a "Since: 0.10.24" tag added to the new enum).

commit 36c496b8f144f6441a46cca86987671f7cddca74
Author: David Biomech360 <ddes310@yahoo.com>
Date:   Mon Dec 19 11:24:31 2011 -0500

    coloreffects: added support for a visual magnifier color filter to be used in gnome-video-effects
    
    https://bugzilla.gnome.org/show_bug.cgi?id=666542