After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666518 - qtif: Add missing libintl.h include
qtif: Add missing libintl.h include
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2011-12-19 14:02 UTC by Vincent Untz
Modified: 2011-12-19 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtif: Add missing libintl.h include (633 bytes, patch)
2011-12-19 14:02 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2011-12-19 14:02:08 UTC 
A recent commit added ngettext() calls, but without the include. This resulted in this:

io-qtif.c: In function 'gdk_pixbuf__qtif_image_load':
io-qtif.c:151:25: warning: implicit declaration of function 'ngettext' [-Wimplicit-function-declaration]
io-qtif.c:154:25: warning: passing argument 4 of 'g_set_error' makes pointer from integer without a cast [enabled by default]
/usr/include/glib-2.0/glib/gerror.h:75:10: note: expected 'const gchar *' but argument is of type 'int'
io-qtif.c:178:33: warning: passing argument 4 of 'g_set_error' makes pointer from integer without a cast [enabled by default]
/usr/include/glib-2.0/glib/gerror.h:75:10: note: expected 'const gchar *' but argument is of type 'int'
io-qtif.c:191:33: warning: passing argument 4 of 'g_set_error' makes pointer from integer without a cast [enabled by default]
/usr/include/glib-2.0/glib/gerror.h:75:10: note: expected 'const gchar *' but argument is of type 'int'
io-qtif.c:245:29: warning: passing argument 4 of 'g_set_error' makes pointer from integer without a cast [enabled by default]
/usr/include/glib-2.0/glib/gerror.h:75:10: note: expected 'const gchar *' but argument is of type 'int'
Comment 1 Vincent Untz 2011-12-19 14:02:21 UTC 
Created attachment 203871 [details] [review]
qtif: Add missing libintl.h include
Comment 2 Matthias Clasen 2011-12-19 14:18:16 UTC 
Please commit, thanks.
Comment 3 Matthias Clasen 2011-12-19 14:18:31 UTC 
Review of attachment 203871 [details] [review]:

Obviously right