Bug 666442 – assertion `listener->priv->window != NULL' failed

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 666442 - assertion `listener->priv->window != NULL' failed


Summary:	assertion `listener->priv->window != NULL' failed


Status:	RESOLVED FIXED

Product:	vinagre
Classification:	Applications
Component:	VNC
Version:	3.2.x
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	vinagre-maint
QA Contact:	vinagre-maint

URL:
Whiteboard:

Duplicates:	670804 (view as bug list)
Depends on:
Blocks:

Reported:	2011-12-18 10:21 UTC by Andrea Corbellini
Modified:	2012-02-26 12:13 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
backtrace (7.35 KB, text/plain) 2011-12-18 11:12 UTC, Andrea Corbellini		Details
backtrace (7.30 KB, text/plain) 2011-12-18 11:17 UTC, Andrea Corbellini		Details
set the window on the reverse vnc listener (812 bytes, patch) 2011-12-18 11:49 UTC, David King	committed	Details \| Review

Description Andrea Corbellini 2011-12-18 10:21:16 UTC

Steps to reproduce:

1. Remote->Reverse Connections->Enable reverse connections
2. Attach a client

The connection is immediately closed and the following appears on stderr:

** (vinagre:16076): CRITICAL **: incoming: assertion `listener->priv->window != NULL' failed

Comment 1 Andrea Corbellini 2011-12-18 11:12:57 UTC

Created attachment 203787 [details]
backtrace

Comment 2 David King 2011-12-18 11:16:21 UTC

(In reply to comment #1)
> Created an attachment (id=203787) [details]
> backtrace

Starting program: /tmp/vinagre/vinagre/vinagre
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffedfa1700 (LWP 8841)]
[New Thread 0x7fffe291a700 (LWP 8842)]
[New Thread 0x7fffe1ae8700 (LWP 8843)]

** CRITICAL **: vinagre_cmd_direct_connect: assertion `VINAGRE_IS_WINDOW (window)' failed

Program received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x0, log_level=<optimized out>,
    format=0x7ffff580b512 "%s: assertion `%s' failed", args1=0x7fffffffd678)
    at /build/buildd/glib2.0-2.30.2/./glib/gmessages.c:577
577	/build/buildd/glib2.0-2.30.2/./glib/gmessages.c: No such file or directory.
	in /build/buildd/glib2.0-2.30.2/./glib/gmessages.c
(gdb) thread apply all bt

+ Trace 229293

Thread 1 (Thread 0x7ffff7fc8940 (LWP 8840))

#0 g_logv
at /build/buildd/glib2.0-2.30.2/./glib/gmessages.c line 577
#1 g_log
at /build/buildd/glib2.0-2.30.2/./glib/gmessages.c line 591
#2 incoming
at vinagre/vinagre-reverse-vnc-listener.c line 180
#3 ffi_call_unix64
from /usr/lib/x86_64-linux-gnu/libffi.so.6
#4 ffi_call
from /usr/lib/x86_64-linux-gnu/libffi.so.6
#5 g_cclosure_marshal_generic
at /build/buildd/glib2.0-2.30.2/./gobject/gclosure.c line 1147
#6 g_closure_invoke
at /build/buildd/glib2.0-2.30.2/./gobject/gclosure.c line 774
#7 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.30.2/./gobject/gsignal.c line 3272
#8 g_signal_emit_valist
at /build/buildd/glib2.0-2.30.2/./gobject/gsignal.c line 3013
#9 g_signal_emit
at /build/buildd/glib2.0-2.30.2/./gobject/gsignal.c line 3060
#10 g_socket_service_incoming
at /build/buildd/glib2.0-2.30.2/./gio/gsocketservice.c line 234
#11 g_socket_service_ready
at /build/buildd/glib2.0-2.30.2/./gio/gsocketservice.c line 297
#12 g_simple_async_result_complete
at /build/buildd/glib2.0-2.30.2/./gio/gsimpleasyncresult.c line 749
#13 complete_in_idle_cb
at /build/buildd/glib2.0-2.30.2/./gio/gsimpleasyncresult.c line 761
#14 g_main_dispatch
at /build/buildd/glib2.0-2.30.2/./glib/gmain.c line 2442
#15 g_main_context_dispatch
at /build/buildd/glib2.0-2.30.2/./glib/gmain.c line 2998
#16 g_main_context_iterate
at /build/buildd/glib2.0-2.30.2/./glib/gmain.c line 3076
#17 g_main_loop_run
at /build/buildd/glib2.0-2.30.2/./glib/gmain.c line 3284
#18 gtk_main
from /usr/lib/libgtk-3.so.0
#19 g_application_run
at /build/buildd/glib2.0-2.30.2/./gio/gapplication.c line 1323
#20 main
at vinagre/vinagre-main.c line 162

Comment 3 Andrea Corbellini 2011-12-18 11:17:15 UTC

Created attachment 203788 [details]
backtrace

Sorry, previously I posted the wrong backtrace (obtained removing the assertion).

Comment 4 David King 2011-12-18 11:49:05 UTC

Created attachment 203791 [details] [review]
set the window on the reverse vnc listener

It looks like the window was never set on the reverse VNC listener object. Can you test the patch, and let me know if it fixes the problem for you?

Comment 5 Andrea Corbellini 2011-12-18 12:26:47 UTC

Perfect, thanks! Works like a charm.

Will the fix be applied just to the master trunk or will you make also a new 3.2.x release?

Comment 6 David King 2011-12-18 12:40:54 UTC

Comment on attachment 203791 [details] [review]
set the window on the reverse vnc listener

Thanks for testing the patch. I pushed it to the gnome-3-2 and master branches as commit d74df1bc99d1bec553d72cad9c7b5f9a3ff60020 and e8052a5d7ef313b89a856b45aee933e20fddd3dc. There is not normally a .3 stable release, but there have been enough changes and fixes that this is now worthwhile, so I will probably make one next week.

Comment 7 David King 2012-02-26 12:13:19 UTC

*** Bug 670804 has been marked as a duplicate of this bug. ***