After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666435 - avdec: use new avcodec_decode_audio4() API
avdec: use new avcodec_decode_audio4() API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-18 05:39 UTC by Matej Knopp
Modified: 2012-11-20 10:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matej Knopp 2011-12-18 05:39:23 UTC 
avcodec_decode_audio3 now fails with custom get_buffer function. The decoder should either set the custom get_buffer only for video or use decode_audio4.
Comment 1 Vincent Penquerc'h 2012-01-17 15:05:53 UTC 
Any more information, such as a repro test file and command line/code ?
Comment 2 Matej Knopp 2012-01-17 19:13:01 UTC 
Unless this got fixed in the meanwhile if you build gst-ffmpeg with recent libav *any* audio file decoding will fail.
Comment 3 Tim-Philipp Müller 2012-01-17 19:29:28 UTC 
Are you using the internal libav snapshot?
Comment 4 Matej Knopp 2012-01-17 19:32:41 UTC 
No, this is with recent libav. I know I shouldn't :) but I suppose gst-ffmpeg libav will eventual get upgraded and this will be broken. I wanted to submit a patch but got too busy.
Comment 5 Sebastian Dröge (slomo) 2012-01-18 07:45:26 UTC 
This fails with gst-ffmpeg GIT too, I've updated it to a newer libav version recently.

I'd say that this is API breakage in libav though, it worked just fine before. Matej, could you file a bug against libav for this? I'll change it to use decode_audio4.
Comment 6 Sebastian Dröge (slomo) 2012-01-18 09:12:47 UTC 
Or maybe not, this will need some refactoring. I've worked around this by just not setting get_buffer() for audio:


commit 99d47920144f08f7efd0ca03ec5ab583046c496d
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Jan 18 10:05:09 2012 +0100

    ffdec: Only set get_buffer() function for video
    
    Fixes bug #666435.
Comment 7 Matej Knopp 2012-01-18 11:00:41 UTC 
That's pretty much what I suggested in first comment, though it's probably not very future proof.
Comment 8 Sebastian Dröge (slomo) 2012-11-20 10:45:06 UTC 
commit 9456fb86c760b178d25ed9d3647bbfb3dceeda70
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Nov 20 11:39:45 2012 +0100

    avauddec: Port to non-deprecated avcodec_decode_audio4() API
    
    Fixes bug #666435.