GNOME Bugzilla – Bug 666406
[Patch] Spell Checker for Commit Messages
Last modified: 2013-07-07 15:08:06 UTC
I've added spell checker support for both the commit message and the tag message. The spell checker can be disabled via the preferences dialog. You can see a screenshot of the feature at: http://www.guyrutenberg.com/wp-content/uploads/2011/12/gitg-spellchecking.png The relevant patch can be pulled from my git repository (see bellow). $ git request-pull origin git://github.com/guyru/gitg.git The following changes since commit 79905400d781f97ddb75055c4936737e2f228f20: Bug 665351: g_thread_init is deprecated in glib 2.31 (2011-12-02 09:29:09 +0100) are available in the git repository at: git://github.com/guyru/gitg.git spellchecker Guy Rutenberg (3): Add spell checking to commit message. Add spell checking to tag messages as well. Add option to enable/disable the spell checker. configure.ac | 2 ++ data/org.gnome.gitg.gschema.xml.in.in | 8 ++++++++ gitg/gitg-commit-view.c | 10 ++++++++++ gitg/gitg-preferences-dialog.c | 8 ++++++++ gitg/gitg-preferences.ui | 17 +++++++++++++++++ gitg/gitg-window.c | 18 ++++++++++++++++++ 6 files changed, 63 insertions(+), 0 deletions(-)
Thanks for the patch, I added some comments in the github repository.
I've followed your comments and fixed the coding style and added the signal thing.
Let's keep comments on patches in bugzilla for reference purposes.
Can you add the git formatted patch here?
Created attachment 205039 [details] [review] git formatted patch for spell checker support I've attached the git patch, I hope it's ok.
This bug report and patch uploaded were against an older version of Gitg. Moving bug to gitg-0.x. Commit feature is not yet implemented in the current version of Gitg. Marking bug as RESOLVED and OBSOLETE.
Thanks for the patch though! We just finished implementing this, based on your patch, in the latest version of gitg (which uses vala instead of C).