After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666357 - Don't claim gst_bin_add, gst_bin_add_many and gst_element_add_pad transfer ownership
Don't claim gst_bin_add, gst_bin_add_many and gst_element_add_pad transfer ow...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 657202
Blocks:
 
 
Reported: 2011-12-16 12:26 UTC by Jens Georg
Modified: 2012-09-28 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jens Georg 2011-12-16 12:26:47 UTC 
They only do if the reference on the GstMiniOobject is floating, but increase the refcount if it isn't.

The behavior is similar to gtk_container_add, but that doesn't claim to transfer ownership. The Vala bindings that are based on this annotation are causing a reference leak since Vala always sinks the reference.
Comment 1 Sebastian Dröge (slomo) 2011-12-16 12:35:07 UTC 
The parameters should be (transfer floating), not (transfer none) or (transfer full)
Comment 2 Pavel Holejsovsky 2012-01-26 10:36:58 UTC 
Input parameters with transfer!=none are generally unsupported by GoI; although g-ir-scanner still accepts them, the support is considered to be removed, and currently bindings generally don't support them.  See bug 630788 for further discussion.

Marking input arguments as (transfer floating) is generally no-op and makes no harm though - as long as g-ir-scanner keeps converting (transfer floating) to (transfer none).
Comment 3 Tim-Philipp Müller 2012-09-28 18:02:21 UTC 
I guess this can be closed as OBSOLETE. Please re-open if there are still issues with 1.0.